Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935634AbdLSKP1 (ORCPT ); Tue, 19 Dec 2017 05:15:27 -0500 Received: from mail-ve1eur01on0098.outbound.protection.outlook.com ([104.47.1.98]:27424 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758106AbdLSKPW (ORCPT ); Tue, 19 Dec 2017 05:15:22 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=tommi.t.rantala@nokia.com; From: Tommi Rantala Subject: intel_pmu_init() extra_attr memory leak To: x86@kernel.org, LKML , Andi Kleen Message-ID: Date: Tue, 19 Dec 2017 12:15:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [131.228.32.186] X-ClientProxiedBy: HE1PR05CA0223.eurprd05.prod.outlook.com (2603:10a6:3:fa::23) To HE1PR07MB1322.eurprd07.prod.outlook.com (2a01:111:e400:59b0::12) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a0148c9b-429f-41bf-2d70-08d546c96849 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(5600026)(4604075)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(2017052603307);SRVR:HE1PR07MB1322; X-Microsoft-Exchange-Diagnostics: 1;HE1PR07MB1322;3:ZztPfGHeR+DxtzK4k29TMtOX5Ik8RTS0BgQPPfcQpP+o1epXLTfOUINZHLH5iejz6XhxrctO0L5KROQdvwSmnPfkZgiQbC9euRMqKUD12RxdsSqegdI7o7McTbn4baukALbA6JgVD9J3YipByyPe43CF4xcqd7jVHhdh7bwaisXg0LUaD4a5vchAzB9ztoDTHt1cqPKxEwniEsBf1rHO41KJBK/MmGdnR/T377yFyhXhOThxXA+e+kMLFDQEgX2v;25:pkUPqi5W29kl4908fCs7SgDS/l2flXD6lOf/sI9n2ovs3V4fF7rFYj4XbShMUtNOLtbhBPbQ3U+cQjYLyle6d1B+vyoskxPlP+/u4XGviuO5Vio4gyA/1yc7i/OCEsNqNtK712tF/1a3+iz6RIYTqZyF2dQmk67WCe/7fyuKCN+Wy6fMjDG082a52Us4M0IYDKuJRj9t7AhtYRfNGyZmpfr7DVRv8bZ5YwIuzwX679zQgRXSRiMDnjWE6/bgqU3m+i/iZYyFeaCuOEpQ1pMU6oYdDkPciFBFlffZDK7E5NXRHIR46oBq5I6JE06+HROE56NRHs0+D44Tlyp2kq5HHq3wKf6cCDUL3EypU4GF8BE=;31:dTZ9JcKqBwG2B/CT9GR4VroJ/U943JwPOaoyDMsIvGhEbFQBrc94QxBQ6kd50xGiWUDe7ksPACgA3nvLe8orTWrM5JdJCkZiPTgPr4rgAsLNYoT93SyJEOB3oAyE/ZsiLyg+USMr4NBCoSgrBzKOjdzToPJZvk79Vy43w9LX+vbUFWyIz49y35PQirz9UCamuZF0nl2eUGtFkgbgVLAjy8w6c/WqtLvtHcTUTUzrPEQ= X-MS-TrafficTypeDiagnostic: HE1PR07MB1322: X-Microsoft-Exchange-Diagnostics: 1;HE1PR07MB1322;20:IbEJaxrEaehD0j26/XErXnRNrA5hnRzijCY+WLott25iDF3pjAePTfX717MELkTeKuEhhg+GAxUJ1mNFXTIHzwqhNK5n2rAVlkuIZ9k9a1kkMsjYimJfsT3jk+c/Vtnfq26oj8+dx8JToOxjpP+HvSCXj4U3LtKrDjJ3DcWfWNvVc/XLExhNTJIDyEBVPsQHQ/2ricXD8Jr5G6dXH5zt9XW2qN1IRm1a6Uiu1rPy08y6k+SdTZdIuE3hmyhuKqokvtKZoertNEgLXGiKCKIN+8D/vKGLJMQEVdahDONVxiMvO3SM9DebuKNwHVJm8ozla4Cw2A1shqV4HiHfR5lqK0vL6mlJhyN7fvAVdozJIB77NgURjR94fwXGa1dybzh8CS0U6CIlWjcMurgncfKSvnrdFDHXUzAzJRahbXAahEardKbn07pX/trOKFJSfivF+L6dV6aOqM1mysBcbms+VrZQ7bUIfz7RXBZIJpVHKScjFqe11KKSfLydtzlSJ1Dv;4:w3iOOQvEXv7f/+NB1/X3YYlKyPE/7NAjsGnzcSvVAwGlEt4HzJOez1qvINBHkEtfBTjqweOOv4dut8tgHTdJSIyd6Cy6+2PHizgQWQxp3b275ZUbP3eBFe0hz8Zh/IUcy5PaST2NTmovRmYs/O1I1WrWBxG0915o7/qo7blI28ZYai2tZCAwdGOmiHyZHlztEsmLNU8E+gGs5qVW3T0IrPVEh06e4nMfvxBS3IM0UvHg2jPv+34AfDTLufop4VCHMPEEGRBnB6dqfryzz+S9OKvPxyIgVOyZ5vE+Ap3eQ1SWAkx7XHdv5tmeTt9T0pXK X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(2401047)(8121501046)(5005006)(3231023)(11241501184)(806099)(10201501046)(3002001)(93006095)(93001095)(6055026)(6041248)(20161123562025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123558100)(20161123555025)(6072148)(201708071742011);SRVR:HE1PR07MB1322;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:HE1PR07MB1322; X-Forefront-PRVS: 052670E5A4 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6049001)(376002)(39860400002)(346002)(396003)(366004)(189003)(199004)(50466002)(64126003)(8936002)(77096006)(31686004)(2906002)(6486002)(8676002)(81166006)(81156014)(83506002)(52146003)(23676004)(67846002)(52116002)(36756003)(53936002)(2486003)(7736002)(305945005)(68736007)(478600001)(31696002)(65956001)(65806001)(66066001)(47776003)(58126008)(110136005)(16576012)(97736004)(86362001)(575784001)(16526018)(25786009)(6116002)(316002)(6666003)(5660300001)(65826007)(3846002)(106356001)(230700001)(105586002)(386003);DIR:OUT;SFP:1102;SCL:1;SRVR:HE1PR07MB1322;H:[10.145.140.58];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtIRTFQUjA3TUIxMzIyOzIzOmxoMmdYMnVETllwTmYzOXMzY0RZamxPYkUx?= =?utf-8?B?NU1qVEw3VFNzdmp1MFBPaXNhUTRkS3ZSYW5IamhoVmdMSEh5L3pRbi9zeGlv?= =?utf-8?B?bE9sK1JPbmR6ayt3eDRFOWNneUJWK1NFWFNESmdsUUF0RnQyZVJXYzBhaUZ3?= =?utf-8?B?aFpxMWJEMXBjY25CblYzcU1xQ29wL0V1QnZJZEVDejFya2FVazl4RU1ZdDk2?= =?utf-8?B?RTAzNjlZRVorcGpVOWp1b3U0RUVwNXNPaWdORzEvbk5odDQ2WVgydmxYLytz?= =?utf-8?B?NjdSdElZSnJFOStVaWZ0ZDZiVHhuMGhxUzJWWW9GM0ROUmdveGlYc0ZKeStI?= =?utf-8?B?bVNpcmREcEVyenJMNkluVSt2clMyU3EzNGE4TmFIT0RlSkdJL1VLR1J5bGow?= =?utf-8?B?VHkxUFFiNStzVlRZUXVLOWhiR2F0WFhpMmZZL29xMVdGSy9EYS8yMGpYTlRO?= =?utf-8?B?SXRMclNxVGJSNkRTcVVXbFR2UVJoR2NjM01MK3RsTklLdFAxenQ3Q0F0OEFB?= =?utf-8?B?dnhKblNkQzZRL0NPRDVpVW5lTXltY2loS3U0YWNBMmc1QmRsQWo4OUxRQ1I2?= =?utf-8?B?cDhHaEJZVmcwSktJSlVnczg3OWNpZ0VSMGlaZlpqbVhkcjVuSWNaTzdkLytm?= =?utf-8?B?MXJySjFFUjU1dWNpRE1IdDBacGdMUE4yb2dqL2tXOEkwL3lYSHVhT0tWODhC?= =?utf-8?B?d1dtQkNOQ01ZN05DNjVmcFo5NDcwVTE2amFhZ1VOTlE5VGZhdFJpMGwwWXcx?= =?utf-8?B?citLcVNIS3M1Wm5CMWdrYU9GQXh1eFhzSTlEdUc1Q2d3M3dYWFdrRjhvTGlp?= =?utf-8?B?S3pReGhhSURlbDZhUlZCdTBkU0pTTmtuZVVCWjFCNGNqRGFtMkdOV2JVZEhF?= =?utf-8?B?UTYvVTJYdVN3bkJnZzU2NkxUMDV3Z0c4N2V3NXNYOHR1UDQzNW03NmlFUnJ6?= =?utf-8?B?LzVySjFTL3ZvVzM1Q25nWFZPaEtBOXBnYVh2d1ZBRHIwYzVDS1NVajNsNVkx?= =?utf-8?B?ME9CNVhwbnVJa2RMS3VYeDE5ZktkeEZva3VIaHFBT2FyKytQRnhOWmxUM0J4?= =?utf-8?B?eDdET0NFSmxrWkw3NkNhcGJHdWhDM2pWMWR5RzYxc3pBUmt1Yk1HNkJoN3pD?= =?utf-8?B?L1BqWVVJSXVFTTIwSEFoM3RGdFlFRm1hOEFUMU9heG5TempYUWwzbG13ZDRr?= =?utf-8?B?RmYwOWNyWW1jc1FoMXZFTVVLMkVMUG1RMXF2MzZteVpFS2JKY2w1ZElhZ1Jr?= =?utf-8?B?SGpKcGw2anRVWHJhUlpVYVlIeWg2MHZKeXBidHFHTjRVenRyT3h2UVBoZXVa?= =?utf-8?B?QnFGTlRLU1RqZWVzVCtqUGNMRkhBRktCWFJqMVRGMmlxd3FnSW1ZeUdYZXhi?= =?utf-8?B?RWFlbDM3NDd6MjhJT3Bob1FreUJQZlczSFpxM1BlVFhueERyU2tZenJmZG9i?= =?utf-8?B?Y1hzWWNYTWdZUDAxT085VEVzeEo5VVdoQVhFalFGa0wzQTlTd0VVdkI5Mndt?= =?utf-8?B?QzVJcnhiNFdzc3dUT0hFd2tNOGRHVzI1Ukh6SVg1WGtLUVVXMmFwa3F0ZnVJ?= =?utf-8?B?U1NiR0xtejhOdXNYcFVRdUhxeG1wS0VnR0ZFM293Q3VDZ09zM2RMQmRUampH?= =?utf-8?B?amloeTZTZ1p6VDVOWk5xVkpoUG1FMEFtTmN4Q2dDb2VHTUFVTmxsY3BRPT0=?= X-Microsoft-Antispam-Message-Info: 8EyubPbeC+8x+XS7dgYKCGyMaBgPRnyHlxaz0l+kEnJ84j74Ufq9uY3pUUOELg86qXl4rFqoo5gLAGDEHRj2Cw== X-Microsoft-Exchange-Diagnostics: 1;HE1PR07MB1322;6:nsMk4ACDritT6D1Y0SgvuBKnL0ywb8dX1Yr9CI9OgKpTyJD7hdV4xhsCqdtswU4klJF6tQkQMBD4y+4x34/O2bt6AQJ3l35mCvdFKahzSK7dALjKpoHRimAGZb74TiyDs1NOVJzJXQKqxXMeYt8Xtv0MRigAd60wPQHq7Ao6JlECq1jr7+bIUnOdtmAhCdIZdNaxSn1Ll9MIj9lm65Caxjo03iCeqhvyEsVQqlvnNriJbryUun6bJa/YFZ2HgHr5F17UA69kLLYxI0SNiBiTLHO88gxIrLZLgpAcC4hur4AYXar+Fazs3QuR64gxcpDjRHP2F60Qn+i7D+76Zgo5B8MK64q2P4M6cMqvI8GRQwg=;5:fiLKlgQCIMe8P04W26/96FQ+OC0degbUpnoXy6UVE8454Q7re8f+9FEa76GLfzpET3Tn2VfOGjrw01EwWFGAbJ1Ej0lGQmtxUTwDsJV94qwz+R118bZdfAXZBeniq5T/VpZMOyOP8Q4ELAgQlqZwF56tr+bFswJIhegIqV8z3jY=;24:5Qw4ZjS5Ab4YbH1yKEVPW8ujbwkCns4XIxgLwMZokgLQEs3IE5jPobp9LemL3kw2oirYbuJAP6VJ+K54mpm8oymj81qbxO9xTruKc1JV7Eo=;7:FH/ZGWaOwEKuRu/ziTE8W3m9JCcV4ZHeqEOy0Cj7h4pacR/tiUqB6Xl9+dkAWdwsD7NOStYmJZhWAvRtycy0OvTRGeuQYSV5FKpOLcUBXAAZGJo5ApS9l6wYKzA1zjmiXyonKhbfo6AF5HbnjL1BKlS4ICcOFYv5bBbDDY5TSI9K52Fk75T9iPlUftJFgdEfvcOhPBCw8dFdjeJc/p9iGqaEBH71B5/puSrYe3tZNc9njSA/jH87H33/N3yv0UQw SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nokia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Dec 2017 10:15:19.1664 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a0148c9b-429f-41bf-2d70-08d546c96849 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5d471751-9675-428d-917b-70f44f9630b0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR07MB1322 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1267 Lines: 43 Hi, I'm seeing this kmemleak report in v4.15-rc4: # cat /sys/kernel/debug/kmemleak unreferenced object 0xffff8801f3d5d720 (size 64): comm "swapper/0", pid 1, jiffies 4294667312 (age 2687.423s) hex dump (first 32 bytes): 60 d1 41 ad ff ff ff ff 20 d1 41 ad ff ff ff ff `.A..... .A..... 80 d0 41 ad ff ff ff ff 40 d0 41 ad ff ff ff ff ..A.....@.A..... backtrace: [<00000000ab01886a>] intel_pmu_init+0x1844/0x1d38 [<00000000cf20c5f0>] init_hw_perf_events+0x8c/0x66f [<00000000dd69189d>] do_one_initcall+0x7b/0x1d0 [<000000008ee1f02a>] kernel_init_freeable+0x163/0x2f9 [<00000000e32ca8d9>] kernel_init+0xf/0x120 [<0000000038a99264>] ret_from_fork+0x24/0x30 [<00000000ace6d26f>] 0xffffffffffffffff $ ./scripts/faddr2line vmlinux intel_pmu_init+0x1844/0x1d38 intel_pmu_init+0x1844/0x1d38: intel_pmu_init at arch/x86/events/intel/core.c:4296 Which matches line: extra_attr = merge_attr(extra_attr, skl_format_attr); So looks like "extra_attr" is leaked here. "git blame" points to this commit: commit a5df70c354c26e20d5fd8eb64517f724e97ef0b2 Author: Andi Kleen Date: Tue Aug 22 11:52:00 2017 -0700 perf/x86: Only show format attributes when supported -Tommi