Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761960AbdLSKl0 (ORCPT ); Tue, 19 Dec 2017 05:41:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48816 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761906AbdLSKlT (ORCPT ); Tue, 19 Dec 2017 05:41:19 -0500 Subject: Re: [PATCH] KVM/Eventfd: Avoid crash when assign and deassign same eventfd in parallel. To: Lan Tianyu , David Hildenbrand Cc: rkrcmar@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, dvyukov@google.com, kernellwp@gmail.com References: <1513554007-12302-1-git-send-email-tianyu.lan@intel.com> From: Paolo Bonzini Message-ID: Date: Tue, 19 Dec 2017 11:41:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Tue, 19 Dec 2017 10:41:19 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1558 Lines: 47 On 19/12/2017 07:35, Lan Tianyu wrote: > On 2017年12月18日 16:50, Paolo Bonzini wrote: >> On 18/12/2017 09:30, David Hildenbrand wrote: >>> The ugly thing in kvm_irqfd_assign() is that we access irqfd without >>> holding a lock. I think that should rather be fixed than working around >>> that issue. (e.g. lock() -> lookup again -> verify still in list -> >>> unlock()) >> >> I wonder if it's even simpler: >> >> diff --git a/virt/kvm/eventfd.c b/virt/kvm/eventfd.c >> index f2ac53ab8243..17ed298bd66f 100644 >> --- a/virt/kvm/eventfd.c >> +++ b/virt/kvm/eventfd.c >> @@ -387,7 +387,6 @@ kvm_irqfd_assign(struct kvm *kvm, struct kvm_irqfd *args) >> >> idx = srcu_read_lock(&kvm->irq_srcu); >> irqfd_update(kvm, irqfd); >> - srcu_read_unlock(&kvm->irq_srcu, idx); >> >> list_add_tail(&irqfd->list, &kvm->irqfds.items); >> >> @@ -420,10 +419,12 @@ kvm_irqfd_assign(struct kvm *kvm, struct kvm_irqfd *args) >> irqfd->consumer.token, ret); >> } >> #endif >> + srcu_read_unlock(&kvm->irq_srcu, idx); >> >> return 0; >> >> fail: >> + /* irq_srcu is *not* held here. */ >> if (irqfd->resampler) >> irqfd_resampler_shutdown(irqfd); >> >> > > Hi Paolo: > This patch still can't prevent from freeing struct irqfd in > irq_shutdown() during assign irqfd. Once irqfd is added to > kvm->irqfds.items list, deassign path can get irqfd and free it. You're right, that also has to be protected by SRCU. So a new bool is needed (probably "active" more than "initialized") in order to replace list_del_init with list_del_rcu. Paolo