Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762021AbdLSKni (ORCPT ); Tue, 19 Dec 2017 05:43:38 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:49688 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758943AbdLSKne (ORCPT ); Tue, 19 Dec 2017 05:43:34 -0500 Date: Tue, 19 Dec 2017 11:43:33 +0100 From: Alexandre Belloni To: Radu Pirea Cc: linux-spi@vger.kernel.org, broonie@kernel.org, nicolas.ferre@microchip.com, Wenyou.Yang@microchip.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2] spi: atmel: Implements transfers with bounce buffer Message-ID: <20171219104333.GL15162@piout.net> References: <1513093032-11570-1-git-send-email-radu.pirea@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1513093032-11570-1-git-send-email-radu.pirea@microchip.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1056 Lines: 32 On 12/12/2017 at 17:37:12 +0200, Radu Pirea wrote: > This patch enables DMA transfers for Atmel SAM9 SoCs and implements a bounce > buffer for transfers which have vmalloc allocated buffers. Those buffers are > not cache coherent even if they have been transformed into sg lists. UBIFS > is affected by this cache coherency issue. > > In this patch I also reverted "spi: atmel: fix corrupted data issue on SAM9 > family SoCs"(7094576ccdc3acfe1e06a1e2ab547add375baf7f). > > > Signed-off-by: Radu Pirea > --- > Please ignore the previous version. I messed up with file names. > drivers/spi/spi-atmel.c | 113 +++++++++++++++++++++++++++++++++++------------- > 1 file changed, 84 insertions(+), 29 deletions(-) > There are multiple checkpatch issues, can you fix them? > + if(!as->use_dma) Especially that missing space. > + dev_info(master->dev.parent, > + " can not allocate dma coherent memory\n"); > + } > + -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com