From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Wang Dongsheng <dongsheng.wang@hxt-semitech.com>,
        "kishon@ti.com" <kishon@ti.com>
CC: "jh80.chung@samsung.com" <jh80.chung@samsung.com>,
        "krzk@kernel.org" <krzk@kernel.org>,
        "heiko@sntech.de" <heiko@sntech.de>,
        "vivek.gautam@codeaurora.org" <vivek.gautam@codeaurora.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] phy: rcar: fix gen3-usb2 build error
Thread-Topic: [PATCH] phy: rcar: fix gen3-usb2 build error
Thread-Index: AQHTeL2m7i0kfRBUQEKbx65vkhrBmKNKjO7g
Date: Tue, 19 Dec 2017 11:51:24 +0000
Message-ID: <TY1PR06MB0992FEBB528234E6A2B944AAD80F0@TY1PR06MB0992.apcprd06.prod.outlook.com>
References: <1513683391-10036-1-git-send-email-dongsheng.wang@hxt-semitech.com>
In-Reply-To: <1513683391-10036-1-git-send-email-dongsheng.wang@hxt-semitech.com>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 0d9afb7e-eb72-4b9b-eb15-08d546d6d454
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Dec 2017 11:51:24.0198
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY1PR06MB0990
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id vBJBpgxS016748
Content-Length: 1384
Lines: 45

Hi Wang-san,

> From: Wang Dongsheng, Sent: Tuesday, December 19, 2017 8:37 PM
> 
> of_usb_get_dr_mode_by_phy is implemented in usb/common/common.c.
> So the PHY_RCAR_GEN3_USB2 must depend on USB_SUPPORT/USB_COMMON.
> 
>  LD      vmlinux.o
>  MODPOST vmlinux.o
> .../phy-rcar-gen3-usb2.o: In function `rcar_gen3_phy_usb2_probe':
> ...: undefined reference to `of_usb_get_dr_mode_by_phy'
> make: *** [vmlinux] Error 1
> 
> Signed-off-by: Wang Dongsheng <dongsheng.wang@hxt-semitech.com>

Thank you for the patch! However, Arnd already sent such a patch before [1]
and it will be merged into the usb repository [2] in near the future.

[1] https://lkml.org/lkml/2017/11/2/373
[2] git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git in the usb-linus branch.

Best regards,
Yoshihiro Shimoda

> ---
>  drivers/phy/renesas/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/phy/renesas/Kconfig b/drivers/phy/renesas/Kconfig
> index cb09245..c845fac 100644
> --- a/drivers/phy/renesas/Kconfig
> +++ b/drivers/phy/renesas/Kconfig
> @@ -12,7 +12,9 @@ config PHY_RCAR_GEN3_USB2
>  	tristate "Renesas R-Car generation 3 USB 2.0 PHY driver"
>  	depends on ARCH_RENESAS
>  	depends on EXTCON
> +	depends on USB_SUPPORT
>  	select GENERIC_PHY
> +	select USB_COMMON
>  	help
>  	  Support for USB 2.0 PHY found on Renesas R-Car generation 3 SoCs.
> 
> --
> 2.7.4