Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763342AbdLSOMY (ORCPT ); Tue, 19 Dec 2017 09:12:24 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:40634 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751084AbdLSOMX (ORCPT ); Tue, 19 Dec 2017 09:12:23 -0500 Date: Tue, 19 Dec 2017 15:12:25 +0100 From: Greg Kroah-Hartman To: Valentin Vidic Cc: Dan Carpenter , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Marcin Ciupak , Marcus Wolf , Simon =?iso-8859-1?Q?Sandstr=F6m?= , Marcus Wolf Subject: Re: [PATCH 6/8 v4] staging: pi433: remove unused function Message-ID: <20171219141225.GB32322@kroah.com> References: <20171213142156.3201-1-Valentin.Vidic@CARNet.hr> <20171213142156.3201-6-Valentin.Vidic@CARNet.hr> <70c9a1fc-31eb-27c4-1283-35590f8b80f6@smarthome-wolf.de> <20171213165514.12509-1-Valentin.Vidic@CARNet.hr> <38352026-045b-a082-93bb-10e9e70f9f55@smarthome-wolf.de> <20171213174444.21088-1-Valentin.Vidic@CARNet.hr> <20171214144215.zj35buhshkayopuj@mwanda> <20171214152020.15859-1-Valentin.Vidic@CARNet.hr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171214152020.15859-1-Valentin.Vidic@CARNet.hr> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 642 Lines: 22 On Thu, Dec 14, 2017 at 04:20:20PM +0100, Valentin Vidic wrote: > As it turns out rf69_get_lna_gain is not used at all. > > Signed-off-by: Valentin Vidic > --- > v2: - drop change for SHIFT_DATAMODUL_MODULATION_TYPE > - move shifting to the header file > v3: - drop auto case > - use CURRENT suffix > - precompute define values > v4: - drop the whole function since it is not called > from anywhere This patch series is crazy, I have no idea how to pick out the "correct" patches here at all. Please just resend the whole thing, as 'v5', in order, so that I know what to do. thanks, greg k-h