Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763589AbdLSOh1 (ORCPT ); Tue, 19 Dec 2017 09:37:27 -0500 Received: from mail-qk0-f194.google.com ([209.85.220.194]:41266 "EHLO mail-qk0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752296AbdLSOhO (ORCPT ); Tue, 19 Dec 2017 09:37:14 -0500 X-Google-Smtp-Source: ACJfBouAWQZsF7bjpHYFk6Q1KUDrSzICPN/fc21Rkro7EqkwB6oSyRGGQ1LkzZHPyNtJge4RSJ/zHP7seplQJ9g3yKw= MIME-Version: 1.0 In-Reply-To: <81459d11-693a-eb51-9173-9c189677f422@users.sourceforge.net> References: <81459d11-693a-eb51-9173-9c189677f422@users.sourceforge.net> From: Andy Shevchenko Date: Tue, 19 Dec 2017 16:37:12 +0200 Message-ID: Subject: Re: [PATCH 0/2] platform/x86/thinkpad_acpi: Adjustments for four function implementations To: SF Markus Elfring Cc: ibm-acpi-devel@lists.sourceforge.net, Platform Driver , Andy Shevchenko , Darren Hart , Henrique de Moraes Holschuh , LKML , kernel-janitors@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 710 Lines: 24 On Mon, Dec 18, 2017 at 11:26 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 18 Dec 2017 22:23:45 +0100 > > Two update suggestions were taken into account > from static source code analysis. > > Markus Elfring (2): > Delete an error message for a failed memory allocation in three functions This one is questionable since it prints error messages at ->init() stage. I would rather not touch this. > Improve a size determination in tpacpi_new_rfkill() Doesn't make any sense right now. One style over the other. Nothing gets better or worth at this point. Sorry, but NAK for both. -- With Best Regards, Andy Shevchenko