Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936866AbdLSO4k (ORCPT ); Tue, 19 Dec 2017 09:56:40 -0500 Received: from mail.CARNet.hr ([161.53.123.6]:43843 "EHLO mail.carnet.hr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935186AbdLSO4g (ORCPT ); Tue, 19 Dec 2017 09:56:36 -0500 From: Valentin Vidic To: Greg Kroah-Hartman Cc: Dan Carpenter , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Marcin Ciupak , Marcus Wolf , =?UTF-8?q?Simon=20Sandstr=C3=B6m?= , Marcus Wolf , Valentin Vidic Date: Tue, 19 Dec 2017 15:56:21 +0100 Message-Id: <20171219145623.24023-4-Valentin.Vidic@CARNet.hr> X-Mailer: git-send-email 2.15.0 In-Reply-To: <20171219145623.24023-1-Valentin.Vidic@CARNet.hr> References: <20171219145623.24023-1-Valentin.Vidic@CARNet.hr> X-SA-Exim-Connect-IP: 2001:b68:ff:12::131 Subject: [PATCH 4/6 v5] staging: pi433: avoid logging ENOMEM messages X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 806 Lines: 29 Fixes checkpatch warning: WARNING: Possible unnecessary 'out of memory' message Signed-off-by: Valentin Vidic --- v5: resend patchset based on comments drivers/staging/pi433/pi433_if.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c index 6e147cd351c7..287bfa4e270f 100644 --- a/drivers/staging/pi433/pi433_if.c +++ b/drivers/staging/pi433/pi433_if.c @@ -937,10 +937,8 @@ static int pi433_open(struct inode *inode, struct file *filp) if (!device->rx_buffer) { device->rx_buffer = kmalloc(MAX_MSG_SIZE, GFP_KERNEL); - if (!device->rx_buffer) { - dev_dbg(device->dev, "open/ENOMEM\n"); + if (!device->rx_buffer) return -ENOMEM; - } } device->users++; -- 2.15.0