Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751509AbdLSPCO (ORCPT ); Tue, 19 Dec 2017 10:02:14 -0500 Received: from mail.kernel.org ([198.145.29.99]:50526 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751141AbdLSPCF (ORCPT ); Tue, 19 Dec 2017 10:02:05 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9CF0420853 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Tue, 19 Dec 2017 10:02:02 -0500 From: Steven Rostedt To: Sebastian Andrzej Siewior Cc: Grygorii Strashko , linux-rt-users , LKML Subject: Re: [v4.14-rt][report] arm: run: stress-ng --class os --all 0 -t 5m Message-ID: <20171219100202.3017a79f@gandalf.local.home> In-Reply-To: <20171219082739.d6oxzkjkdicfu3hq@linutronix.de> References: <20171219082739.d6oxzkjkdicfu3hq@linutronix.de> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 873 Lines: 27 On Tue, 19 Dec 2017 09:27:40 +0100 Sebastian Andrzej Siewior wrote: > diff --git a/kernel/time/hrtimer.c b/kernel/time/hrtimer.c > index c2c344fda487..3971fa0c7194 100644 > --- a/kernel/time/hrtimer.c > +++ b/kernel/time/hrtimer.c > @@ -1952,6 +1952,7 @@ int hrtimers_dead_cpu(unsigned int scpu) > BUG_ON(cpu_online(scpu)); > tick_cancel_sched_timer(scpu); > > + local_bh_disable(); > local_irq_disable(); > old_base = &per_cpu(hrtimer_bases, scpu); > new_base = this_cpu_ptr(&hrtimer_bases); > @@ -1979,6 +1980,7 @@ int hrtimers_dead_cpu(unsigned int scpu) > /* Check, if we got expired work to do */ > __hrtimer_peek_ahead_timers(); > local_irq_enable(); > + local_bh_enable(); > return 0; > } The above just seems wrong. local_irq_disable() should imply local_bh_disable(), as it doesn't let softirqs run either. -- Steve