Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753973AbdLSPgj (ORCPT ); Tue, 19 Dec 2017 10:36:39 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:51876 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752989AbdLSPgf (ORCPT ); Tue, 19 Dec 2017 10:36:35 -0500 Date: Tue, 19 Dec 2017 10:36:33 -0500 (EST) Message-Id: <20171219.103633.721139612524381957.davem@davemloft.net> To: yanhaishuang@cmss.chinamobile.com Cc: kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, u9012063@gmail.com Subject: Re: [PATCH v2,net-next 1/2] ip_gre: fix potential memory leak in erspan_rcv From: David Miller In-Reply-To: <1513392519-30127-1-git-send-email-yanhaishuang@cmss.chinamobile.com> References: <1513392519-30127-1-git-send-email-yanhaishuang@cmss.chinamobile.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 19 Dec 2017 07:36:35 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 574 Lines: 18 From: Haishuang Yan Date: Sat, 16 Dec 2017 10:48:38 +0800 > If md is NULL, tun_dst must be freed, otherwise it will cause memory > leak. > > Fixes: 1a66a836da6 ("gre: add collect_md mode to ERSPAN tunnel") > Cc: William Tu > Signed-off-by: Haishuang Yan > > Change since v2: > * Rebase on latest master branch. > * Correct wrong fix information. Please do not put a changelog after the fixes and signoff tags, those tags must appear last in the commit message. Thank you.