Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752120AbdLSP4B (ORCPT ); Tue, 19 Dec 2017 10:56:01 -0500 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:43333 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751517AbdLSPzz (ORCPT ); Tue, 19 Dec 2017 10:55:55 -0500 Subject: Re: [PATCH V2 3/9] ARM: stm32: prepare stm32 family to welcome armv7 architecture To: Arnd Bergmann CC: Russell King , Rob Herring , Linus Walleij , Maxime Coquelin , Alexandre Torgue , Gerald Baeza , Linux ARM , Linux Kernel Mailing List , DTML References: <1513610272-7824-1-git-send-email-ludovic.Barre@st.com> <1513610272-7824-4-git-send-email-ludovic.Barre@st.com> <45e2f530-1e72-6933-4367-95aadd709873@st.com> From: Ludovic BARRE Message-ID: <00e3d1b3-56cc-f003-9538-0cc769a00c9c@st.com> Date: Tue, 19 Dec 2017 16:54:57 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.50] X-ClientProxiedBy: SFHDAG8NODE3.st.com (10.75.127.24) To SFHDAG6NODE1.st.com (10.75.127.16) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-12-19_08:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2016 Lines: 78 On 12/19/2017 04:26 PM, Arnd Bergmann wrote: > On Tue, Dec 19, 2017 at 3:43 PM, Ludovic BARRE wrote: >> >> >> On 12/18/2017 09:24 PM, Arnd Bergmann wrote: >>> >>> On Mon, Dec 18, 2017 at 4:17 PM, Ludovic Barre >>> wrote: >>>> >>>> From: Ludovic Barre >>>> >>>> This patch prepares the STM32 machine for the integration of Cortex-A >>>> based microprocessor (MPU), on top of the existing Cortex-M >>>> microcontroller family (MCU). Since both MCUs and MPUs are sharing >>>> common hardware blocks we can keep using ARCH_STM32 flag for most of >>>> them. If a hardware block is specific to one family we can use either >>>> ARM_SINGLE_ARMV7M or ARCH_MULTI_V7 flag. >>>> >>>> Signed-off-by: Ludovic Barre >>> >>> >>> Looks good overall. Two more small comments: >>> >>> >>>> >>>> +if ARCH_STM32 >>>> + >>>> config MACH_STM32F429 >>>> - bool "STMicrolectronics STM32F429" >>>> - depends on ARCH_STM32 >>>> + bool "STMicroelectronics STM32F429" >>>> + depends on ARM_SINGLE_ARMV7M >>>> default y >>> >>> >>> Instead of the explicit dependency for each board, I'd leave the >>> surrounding >>> 'if ARM_SINGLE_ARMV7M'. I think you had in v1. >> >> >> As you suggest, I follow mach-at91 example. >> The point is on "depends on ARM_SINGLE_ARMV7M" ? >> You prefer this way: >> config MACH_STM32F429 >> bool "STMicroelectronics STM32F429" if ARM_SINGLE_ARMV7M >> default y >> > > No, that would be wrong, that way you would always enable > MACH_STM32F429 when ARM_SINGLE_ARMV7M is turned > off, which is exactly the wrong way round. What I meant is > > if ARCH_STM32 > > if ARM_SINGLE_ARMV7M > > config MACH_STM32F429 > bool "STMicrolectronics STM32F429" > > config MACH_STM32... > ... > > endif # ARMv7-M > > if ARCH_MULTI_V7 > > config MACH_STM32... > ... > > endif # ARMv7-A > > endif # STM32 > > Arnd > Ok, it's clear :-)