Message-ID: <1513700059.1234.42.camel@perches.com>
Subject: Re: [PATCH v7 1/3] lib: Add strongly typed 64bit int_sqrt
From: Joe Perches <joe@perches.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Crt Mori <cmo@melexis.com>, Jonathan Cameron <jic23@kernel.org>,
        Ingo Molnar <mingo@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Kees Cook <keescook@chromium.org>,
        Rusty Russell <rusty@rustcorp.com.au>, Ian Abbott <abbotti@mev.co.uk>,
        Larry Finger <Larry.Finger@lwfinger.net>,
        Niklas Soderlund <niklas.soderlund+renesas@ragnatech.se>,
        Thomas Gleixner <tglx@linutronix.de>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        Masahiro Yamada <yamada.masahiro@socionext.com>,
        linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org
Date: Tue, 19 Dec 2017 08:14:19 -0800
In-Reply-To: <20171219161245.cbjmod7ak5scio7d@hirez.programming.kicks-ass.net>
References: <20171219155908.29528-1-cmo@melexis.com>
         <1513699793.1234.41.camel@perches.com>
         <20171219161245.cbjmod7ak5scio7d@hirez.programming.kicks-ass.net>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 343
Lines: 15

On Tue, 2017-12-19 at 17:12 +0100, Peter Zijlstra wrote:
> On Tue, Dec 19, 2017 at 08:09:53AM -0800, Joe Perches wrote:
> > 
> > I suspect you need to define this as:
> > 
> > #define int_sqrt64(x) ((u32)int_sqrt(x))
> 
> What's wrong with using C ?

Duh.  Nothing at all.

> static inline u32 int_sqrt64(u64 x)
> {
> 	return int_sqrt(x);
> }