Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752781AbdLSRMj (ORCPT ); Tue, 19 Dec 2017 12:12:39 -0500 Received: from mail.kernel.org ([198.145.29.99]:33768 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751236AbdLSRMg (ORCPT ); Tue, 19 Dec 2017 12:12:36 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7ECF521927 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=robh@kernel.org X-Google-Smtp-Source: ACJfBothzld0GzB8g6ucbUHrbLGABPuj0vvypoVK8c4RB/gLfb+WvRlzaHsmWvKOI3/YXmHAAEnMJi9QL3V4nz4RWB8= MIME-Version: 1.0 In-Reply-To: <1b230e6b-8e8c-28a4-7524-6ce60aa71591@skidata.com> References: <20171211121700.10200-1-dev@g0hl1n.net> <20171211121700.10200-2-dev@g0hl1n.net> <20171215221752.42sz53izxeebkfuq@rob-hp-laptop> <1b230e6b-8e8c-28a4-7524-6ce60aa71591@skidata.com> From: Rob Herring Date: Tue, 19 Dec 2017 11:12:13 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH net-next v5 1/4] phylib: Add device reset delay support To: Richard Leitner Cc: Richard Leitner , Mark Rutland , Fugang Duan , Andrew Lunn , Florian Fainelli , Frank Rowand , David Miller , Geert Uytterhoeven , Sergei Shtylyov , Baruch Siach , David Wu , Lukasz Majewski , netdev , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2316 Lines: 55 On Mon, Dec 18, 2017 at 1:30 AM, Richard Leitner wrote: > Hi Rob, > > On 12/15/2017 11:17 PM, Rob Herring wrote: >> On Mon, Dec 11, 2017 at 01:16:57PM +0100, Richard Leitner wrote: >>> From: Richard Leitner >>> >>> Some PHYs need a minimum time after the reset gpio was asserted and/or >>> deasserted. To ensure we meet these timing requirements add two new >>> optional devicetree parameters for the phy: reset-delay-us and >>> reset-post-delay-us. >>> >>> Signed-off-by: Richard Leitner >>> Reviewed-by: Geert Uytterhoeven >>> --- >>> Documentation/devicetree/bindings/net/phy.txt | 10 ++++++++++ >>> drivers/net/phy/mdio_device.c | 13 +++++++++++-- >>> drivers/of/of_mdio.c | 4 ++++ >>> include/linux/mdio.h | 2 ++ >>> 4 files changed, 27 insertions(+), 2 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/net/phy.txt b/Documentation/devicetree/bindings/net/phy.txt >>> index c05479f5ac7c..72860ce7f610 100644 >>> --- a/Documentation/devicetree/bindings/net/phy.txt >>> +++ b/Documentation/devicetree/bindings/net/phy.txt >>> @@ -55,6 +55,12 @@ Optional Properties: >>> >>> - reset-gpios: The GPIO phandle and specifier for the PHY reset signal. >>> >>> +- reset-delay-us: Delay after the reset was asserted in microseconds. >>> + If this property is missing the delay will be skipped. >>> + >>> +- reset-post-delay-us: Delay after the reset was deasserted in microseconds. >>> + If this property is missing the delay will be skipped. >> >> I think these names could be clearer as to exactly what they mean. >> Looking at existing properties with "reset-delay" there's a mixture of >> definitions whether it is the assert time or the time after deassert. >> >> So I'd call these "reset-assert-us" and "reset-deassert-us". > > Ok, that would be fine with me, but are you sure that we should omit the > "-delay" term completely? These are just minimum assertion and deassertion times. I think that's clear enough. > What would be the best approach to post this change (as the patchset was > already merged to net-next)? A separate patch or a v6 of the complete > patchset? A patch on top of this. Rob