Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753168AbdLSRNJ (ORCPT ); Tue, 19 Dec 2017 12:13:09 -0500 Received: from bombadil.infradead.org ([65.50.211.133]:44984 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753114AbdLSRND (ORCPT ); Tue, 19 Dec 2017 12:13:03 -0500 Date: Tue, 19 Dec 2017 09:12:54 -0800 From: Matthew Wilcox To: Joe Perches Cc: linux-kernel@vger.kernel.org, Ross Zwisler , Dave Hansen , linux-mm@kvack.org, Josh Triplett , Matthew Wilcox Subject: Re: [PATCH 1/2] mm: Make follow_pte_pmd an inline Message-ID: <20171219171254.GD30842@bombadil.infradead.org> References: <20171219165823.24243-1-willy@infradead.org> <1513703142.1234.53.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1513703142.1234.53.camel@perches.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 516 Lines: 13 On Tue, Dec 19, 2017 at 09:05:42AM -0800, Joe Perches wrote: > On Tue, 2017-12-19 at 08:58 -0800, Matthew Wilcox wrote: > > + /* (void) is needed to make gcc happy */ > > + (void) __cond_lock(*ptlp, > > + !(res = __follow_pte_pmd(mm, address, start, end, > > + ptepp, pmdpp, ptlp))); > > This seems obscure and difficult to read. Perhaps: > > res = __follow_pte_pmd(mm, address, start, end, ptepp, pmdpp, ptlp); > (void)__cond_lock(*ptlp, !res); Patch 1 moves the code. Patch 2 cleans it up ;-)