Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752135AbdLSScg (ORCPT ); Tue, 19 Dec 2017 13:32:36 -0500 Received: from mail-lf0-f65.google.com ([209.85.215.65]:43785 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750849AbdLSScb (ORCPT ); Tue, 19 Dec 2017 13:32:31 -0500 X-Google-Smtp-Source: ACJfBovTy/RWtMLDe8dzd/iZK01Cr1Ekz/eVQPUwdSS9rrTDvCOfctZGKZuWptrFGLj9R4T97f3qbA== Subject: Re: [PATCH v2 4/4] usb: host: ehci-tegra: Remove USB_PHY dependencies from Kconfig To: Alan Stern Cc: Felipe Balbi , Greg Kroah-Hartman , Jonathan Hunter , Thierry Reding , linux-usb@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org References: From: Dmitry Osipenko Message-ID: <74c031eb-64eb-5ff6-0c44-c1ab734e4dfc@gmail.com> Date: Tue, 19 Dec 2017 21:32:27 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1914 Lines: 49 On 19.12.2017 20:52, Alan Stern wrote: > On Sun, 17 Dec 2017, Dmitry Osipenko wrote: > >> Previously tegra-phy driver was built only when ehci-tegra was, now >> tegra-phy has its own Kconfig entry. Remove the USB_PHY dependencies >> from ehci-tegra's Kconfig since they aren't useful anymore. > > Are you sure they aren't useful? Does this mean it is now > possible/useful to configure a kernel with USB_EHCI_TEGRA enabled and > USB_PHY disabled? I'm not entirely sure that USB_TEGRA_PHY isn't useful because initially (in V1) I proposed to do the other way around, to select PHY when ehci-tegra / chipidea drivers are enabled. But that proposal wasn't very successful [0][1]. Yes, it means that ehci-tegra could be built without the tegra-phy. The USB_ULPI option isn't needed for compiling ehci-tegra, but for tegra-phy driver. I've moved that option to the tegra-phy's Kconfig, see the previous patch in the series ("Add Kconfig entry for Tegra PHY driver"). [0] https://marc.info/?l=linux-tegra&m=151307881119328 [1] https://marc.info/?l=linux-tegra&m=151294749618823 >> Signed-off-by: Dmitry Osipenko >> --- >> drivers/usb/host/Kconfig | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig >> index 6150bed7cfa8..5042e72c1b76 100644 >> --- a/drivers/usb/host/Kconfig >> +++ b/drivers/usb/host/Kconfig >> @@ -234,9 +234,6 @@ config USB_EHCI_TEGRA >> tristate "NVIDIA Tegra HCD support" >> depends on ARCH_TEGRA >> select USB_EHCI_ROOT_HUB_TT >> - select USB_PHY >> - select USB_ULPI >> - select USB_ULPI_VIEWPORT > > Maybe you should add > > select USB_TEGRA_PHY > > here. Also, what happened to USB_ULPI_VIEWPORT? Is it still > important? If not, then what changed? USB_ULPI_VIEWPORT is selected by USB_ULPI, so we don't need to duplicate the selection. See drivers/usb/phy/Kconfig.