Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751784AbdLSS7W (ORCPT ); Tue, 19 Dec 2017 13:59:22 -0500 Received: from mail-it0-f41.google.com ([209.85.214.41]:37208 "EHLO mail-it0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750953AbdLSS7S (ORCPT ); Tue, 19 Dec 2017 13:59:18 -0500 X-Google-Smtp-Source: ACJfBotwFBFxb0A4gzRAvmUz1bpdAUz5POrwYRgu7/99vleYIC0WdLLLLlBZpdbWCGNjVa7BkLdAhzqt0u8IeFkDMKE= MIME-Version: 1.0 In-Reply-To: <20171219.134810.48027351795338458.davem@davemloft.net> References: <1513588684-15647-1-git-send-email-mw@semihalf.com> <20171219.134810.48027351795338458.davem@davemloft.net> From: Marcin Wojtas Date: Tue, 19 Dec 2017 19:59:17 +0100 Message-ID: Subject: Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support To: David Miller Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev , Russell King - ARM Linux , "Rafael J. Wysocki" , Andrew Lunn , Florian Fainelli , =?UTF-8?Q?Antoine_T=C3=A9nart?= , Thomas Petazzoni , =?UTF-8?Q?Gregory_Cl=C3=A9ment?= , Ezequiel Garcia , nadavh@marvell.com, Neta Zur Hershkovits , Ard Biesheuvel , Grzegorz Jaszczyk , Tomasz Nowicki Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 938 Lines: 26 Hi David, 2017-12-19 19:48 GMT+01:00 David Miller : > From: Marcin Wojtas > Date: Mon, 18 Dec 2017 10:17:56 +0100 > >> Above support configures 1G to use its PHY normally. 10G can work now >> only with the link interrupt mode. Somehow reading of the >> string property in fwnode_mdiobus_child_is_phy works only with >> DT and cannot cope with 10G PHY nodes as in: >> https://pastebin.com/3JnYpU0A >> >> Above root cause will be further checked. In the meantime I will >> appreciate any comments or remarks for the kernel patches. > > I would like you to figure this out before these changes go in. > Of course! v2 will not have such problem, I've been waiting however for the feedback about the ACPI representation. Anyway, I'm strongly leaning towards using _ADR/_CID objects in PHY's nodes for ACPI, so maybe I'll just issue the v2 in order to push the discussion a bit forward. Thanks, Marcin