Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752345AbdLSTM0 (ORCPT ); Tue, 19 Dec 2017 14:12:26 -0500 Received: from bombadil.infradead.org ([65.50.211.133]:34699 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750953AbdLSTMX (ORCPT ); Tue, 19 Dec 2017 14:12:23 -0500 Date: Tue, 19 Dec 2017 11:12:22 -0800 From: Matthew Wilcox To: rao.shoaib@oracle.com Cc: linux-kernel@vger.kernel.org, paulmck@linux.vnet.ibm.com, brouer@redhat.com, linux-mm@kvack.org Subject: Re: [PATCH] kfree_rcu() should use the new kfree_bulk() interface for freeing rcu structures Message-ID: <20171219191222.GA6515@bombadil.infradead.org> References: <1513705948-31072-1-git-send-email-rao.shoaib@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1513705948-31072-1-git-send-email-rao.shoaib@oracle.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 692 Lines: 16 On Tue, Dec 19, 2017 at 09:52:27AM -0800, rao.shoaib@oracle.com wrote: > This patch updates kfree_rcu to use new bulk memory free functions as they > are more efficient. It also moves kfree_call_rcu() out of rcu related code to > mm/slab_common.c > > Signed-off-by: Rao Shoaib > --- > include/linux/mm.h | 5 ++ > kernel/rcu/tree.c | 14 ---- > kernel/sysctl.c | 40 +++++++++++ > mm/slab.h | 23 +++++++ > mm/slab_common.c | 198 ++++++++++++++++++++++++++++++++++++++++++++++++++++- > 5 files changed, 264 insertions(+), 16 deletions(-) You've added an awful lot of code. Do you have any performance measurements that shows this to be a win?