Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752222AbdLSTSp (ORCPT <rfc822;w@1wt.eu>);
        Tue, 19 Dec 2017 14:18:45 -0500
Received: from shards.monkeyblade.net ([184.105.139.130]:55412 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751110AbdLSTSm (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 19 Dec 2017 14:18:42 -0500
Date: Tue, 19 Dec 2017 14:18:40 -0500 (EST)
Message-Id: <20171219.141840.1031328928935244349.davem@davemloft.net>
To: lipeng321@huawei.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        linuxarm@huawei.com, salil.mehta@huawei.com
Subject: Re: [PATCH V2 net-next 02/17] net: hns3: add support to modify
 tqps number
From: David Miller <davem@davemloft.net>
In-Reply-To: <1513656159-127589-3-git-send-email-lipeng321@huawei.com>
References: <1513656159-127589-1-git-send-email-lipeng321@huawei.com>
        <1513656159-127589-3-git-send-email-lipeng321@huawei.com>
X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 19 Dec 2017 11:18:41 -0800 (PST)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 705
Lines: 26

From: Lipeng <lipeng321@huawei.com>
Date: Tue, 19 Dec 2017 12:02:24 +0800

> @@ -2651,6 +2651,19 @@ static int hns3_get_ring_config(struct hns3_nic_priv *priv)
>  	return ret;
>  }
>  
> +static void hns3_put_ring_config(struct hns3_nic_priv *priv)
> +{
> +	struct hnae3_handle *h = priv->ae_handle;
> +	u16 i;
> +
> +	for (i = 0; i < h->kinfo.num_tqps; i++) {

Please use a plain "int" for index iteration loops like this since
that is the canonical type to use.

> +static void hclge_release_tqp(struct hclge_vport *vport)
> +{
> +	struct hnae3_knic_private_info *kinfo = &vport->nic.kinfo;
> +	struct hclge_dev *hdev = vport->back;
> +	u16 i;
> +
> +	for (i = 0; i < kinfo->num_tqps; i++) {

Likewise.