Date: Tue, 19 Dec 2017 11:50:57 -0800
From: Sinclair Yeh <syeh@vmware.com>
To: Woody Suwalski <terraluna977@gmail.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
        DRI mailing list <dri-devel@lists.freedesktop.org>,
        LKML <linux-kernel@vger.kernel.org>, Dave Airlie <airlied@linux.ie>
Subject: Re: [PATCH v.2] 4.15 vmgfx boot warning
Message-ID: <20171219195056.GB9578@vmware.com>
References: <c845316e-c0f8-9ef7-2bf5-97418d8094c7@gmail.com>
 <20171213212522.GC16788@promb-2n-dhcp36.eng.vmware.com>
 <1d88409f-23c4-6706-7111-00f2d13f3351@gmail.com>
 <5508ddeb-ef4d-abfa-2573-717066448a43@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <5508ddeb-ef4d-abfa-2573-717066448a43@gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Dec 2017 19:53:33.6731 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 7bd81772-2243-4502-95bb-08d5471a3047
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR05MB3293
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1598
Lines: 43

This looks okay to me.

On Mon, Dec 18, 2017 at 07:26:03PM -0500, Woody Suwalski wrote:
> The 4.15 drm_atomic_helper driver shows a warning during boot (both 32 and
> 64 bit x86)
> It is caused by a mismatch between the result of vmw_enable_vblank() and
> what the drm_atomic_helper expects:
> ?? /...
> ?? ret = drm_crtc_vblank_get(crtc);
> ?? WARN_ONCE(ret != -EINVAL, "driver forgot to call
> drm_crtc_vblank_off()\n");
> ?? /...
> 
> Signed-off by: Woody Suwalski <terraluna977@gmail.com>
> 
> --- a/drivers/gpu/drm/drm_atomic_helper.c??? 2017-12-16 09:55:33.853374561
> -0500
> +++ b/drivers/gpu/drm/drm_atomic_helper.c??? 2017-12-16 10:55:56.089090752
> -0500
> @@ -889,7 +889,7 @@ disable_outputs(struct drm_device *dev,
> ???? ??? ??? continue;
> 
> ???? ??? ret = drm_crtc_vblank_get(crtc);
> -??? ??? WARN_ONCE(ret != -EINVAL, "driver forgot to call
> drm_crtc_vblank_off()\n");
> +??? ??? WARN_ONCE((ret != -EINVAL && ret != -ENOSYS), "driver forgot to
> call drm_crtc_vblank_off()\n");
> ???? ??? if (ret == 0)
> ???? ??? ??? drm_crtc_vblank_put(crtc);
> ???? }
> 

> --- a/drivers/gpu/drm/drm_atomic_helper.c	2017-12-16 09:55:33.853374561 -0500
> +++ b/drivers/gpu/drm/drm_atomic_helper.c	2017-12-16 10:55:56.089090752 -0500
> @@ -889,7 +889,7 @@ disable_outputs(struct drm_device *dev,
>  			continue;
>  
>  		ret = drm_crtc_vblank_get(crtc);
> -		WARN_ONCE(ret != -EINVAL, "driver forgot to call drm_crtc_vblank_off()\n");
> +		WARN_ONCE((ret != -EINVAL && ret != -ENOSYS), "driver forgot to call drm_crtc_vblank_off()\n");
>  		if (ret == 0)
>  			drm_crtc_vblank_put(crtc);
>  	}