Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752447AbdLST5Q (ORCPT ); Tue, 19 Dec 2017 14:57:16 -0500 Received: from mail-ot0-f195.google.com ([74.125.82.195]:38547 "EHLO mail-ot0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751499AbdLST5M (ORCPT ); Tue, 19 Dec 2017 14:57:12 -0500 X-Google-Smtp-Source: ACJfBosKHD39X6SnDeAucstRtbuFAxndQsWkccy7pSMl2eF2BEMme3J5ZwM6FTXmj6jKmxTGSy/1JA== From: Laura Abbott To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Alexander Shishkin , Jiri Olsa , Namhyung Kim Cc: Laura Abbott , linux-kernel@vger.kernel.org Subject: [PATCH 2/2] perf: Don't make sourced script executable Date: Tue, 19 Dec 2017 11:57:05 -0800 Message-Id: <20171219195705.1853-1-labbott@redhat.com> X-Mailer: git-send-email 2.14.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 966 Lines: 26 rpm lint flagged this: perf.x86_64: E: executable-sourced-script /etc/bash_completion.d/perf 755 Make this not be executable Signed-off-by: Laura Abbott --- tools/perf/Makefile.perf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf index 68cf1360a3f3..a072790f5fad 100644 --- a/tools/perf/Makefile.perf +++ b/tools/perf/Makefile.perf @@ -789,7 +789,7 @@ ifndef NO_LIBPYTHON endif $(call QUIET_INSTALL, perf_completion-script) \ $(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(sysconfdir_SQ)/bash_completion.d'; \ - $(INSTALL) perf-completion.sh '$(DESTDIR_SQ)$(sysconfdir_SQ)/bash_completion.d/perf' + $(INSTALL) -m 644 perf-completion.sh '$(DESTDIR_SQ)$(sysconfdir_SQ)/bash_completion.d/perf' $(call QUIET_INSTALL, perf-tip) \ $(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(tip_instdir_SQ)'; \ $(INSTALL) Documentation/tips.txt -t '$(DESTDIR_SQ)$(tip_instdir_SQ)' -- 2.14.3