Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752623AbdLSUCR (ORCPT ); Tue, 19 Dec 2017 15:02:17 -0500 Received: from aserp2130.oracle.com ([141.146.126.79]:44820 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752049AbdLSUCO (ORCPT ); Tue, 19 Dec 2017 15:02:14 -0500 Subject: Re: [PATCH] kfree_rcu() should use the new kfree_bulk() interface for freeing rcu structures To: Christopher Lameter Cc: linux-kernel@vger.kernel.org, paulmck@linux.vnet.ibm.com, brouer@redhat.com, linux-mm@kvack.org References: <1513705948-31072-1-git-send-email-rao.shoaib@oracle.com> From: Rao Shoaib Message-ID: Date: Tue, 19 Dec 2017 12:02:03 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8750 signatures=668650 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=9 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=932 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1712190286 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 910 Lines: 27 On 12/19/2017 11:33 AM, Christopher Lameter wrote: > On Tue, 19 Dec 2017, rao.shoaib@oracle.com wrote: > >> This patch updates kfree_rcu to use new bulk memory free functions as they >> are more efficient. It also moves kfree_call_rcu() out of rcu related code to >> mm/slab_common.c > It would be great to have separate patches so that we can review it > properly: > > 1. Move the code into slab_common.c > 2. The actual code changes to the kfree rcu mechanism > 3. The whitespace changes > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email@kvack.org I can certainly break down the patch and submit smaller patches as you have suggested. BTW -- This is my first ever patch to Linux, so I am still learning the etiquette. Shoaib