Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752900AbdLSVTg (ORCPT <rfc822;w@1wt.eu>);
        Tue, 19 Dec 2017 16:19:36 -0500
Received: from mail-wm0-f47.google.com ([74.125.82.47]:43486 "EHLO
        mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751013AbdLSVTe (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 19 Dec 2017 16:19:34 -0500
X-Google-Smtp-Source: ACJfBovIgdvmjSKJdtkLjmh4cC/UFDikubCavlnmIsy+OkjtylZew/WOgkN+wNvTXSdXuWasgEQ5bg==
Subject: Re: [PATCH RFC 2/7] KVM: nVMX: modify vmcs12 fields to match Hyper-V
 enlightened VMCS
To: Jim Mattson <jmattson@google.com>
Cc: Vitaly Kuznetsov <vkuznets@redhat.com>, kvm list <kvm@vger.kernel.org>,
        the arch/x86 maintainers <x86@kernel.org>,
        =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        "K. Y. Srinivasan" <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        Stephen Hemminger <sthemmin@microsoft.com>,
        "Michael Kelley (EOSG)" <Michael.H.Kelley@microsoft.com>,
        Mohammed Gamal <mmorsy@redhat.com>, Cathy Avery <cavery@redhat.com>,
        Bandan Das <bsd@redhat.com>, Roman Kagan <rkagan@virtuozzo.com>,
        LKML <linux-kernel@vger.kernel.org>, devel@linuxdriverproject.org
References: <20171218171742.5765-1-vkuznets@redhat.com>
 <20171218171742.5765-3-vkuznets@redhat.com>
 <CALMp9eT2j3bVnLn1_=x6LiVR=3Akxkt8y0We4rpNOpfgMxCyRg@mail.gmail.com>
 <CALMp9eThLdEUEcVOuyARP59_tv9pu5keGw4N5TCZ7MXjh4OiWg@mail.gmail.com>
 <87zi6elxaw.fsf@vitty.brq.redhat.com>
 <db52a041-adb6-f108-efac-86378b7206be@redhat.com>
 <CALMp9eTVV7EunsGFgypVXwncvQo_tDCV2NgrOOprzCbs=U-p0Q@mail.gmail.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <c362b8a3-cccc-97d7-4f4f-88f5b467606a@redhat.com>
Date: Tue, 19 Dec 2017 22:19:30 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <CALMp9eTVV7EunsGFgypVXwncvQo_tDCV2NgrOOprzCbs=U-p0Q@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 437
Lines: 10

On 19/12/2017 18:40, Jim Mattson wrote:
> I'm not sure that's really the right way to go, since any guest that
> has already read the IA32_VMX_BASIC MSR has a right to expect the VMCS
> revision to remain unchanged.

Hmm, not just that, "the VMCS revision identifier is never written by
the processor" according to the SDM.  Maybe the code that accesses the
vmcs12 can be placed in a .h file and included more than once in vmx.c.

Paolo