Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753228AbdLSVy7 (ORCPT ); Tue, 19 Dec 2017 16:54:59 -0500 Received: from mail-vk0-f43.google.com ([209.85.213.43]:41067 "EHLO mail-vk0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752103AbdLSVy6 (ORCPT ); Tue, 19 Dec 2017 16:54:58 -0500 X-Google-Smtp-Source: ACJfBoshB2FbZwHC0jIsP2cz8UxGQGDZMz+X+5YlqmbAZYZD0aqMLDjUT7mWVUksMAupXWv93D97uVBR+RlMJRLtsec= MIME-Version: 1.0 In-Reply-To: References: <001a113e9ca8a3affd05609d7ccf@google.com> <6a50d160-56d0-29f9-cfed-6c9202140b43@I-love.SAKURA.ne.jp> <20171219083746.GR19604@eros> <20171219132246.GD13680@bombadil.infradead.org> From: Kees Cook Date: Tue, 19 Dec 2017 13:54:56 -0800 X-Google-Sender-Auth: bfRToKnyjhdjXoTcClyrDKEzU7w Message-ID: Subject: Re: BUG: bad usercopy in memdup_user To: Linus Torvalds Cc: Matthew Wilcox , "Tobin C. Harding" , Dmitry Vyukov , Tetsuo Handa , Linux-MM , syzbot , David Windsor , keun-o.park@darkmatter.ae, Laura Abbott , LKML , Mark Rutland , Ingo Molnar , syzkaller-bugs@googlegroups.com, Will Deacon Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 444 Lines: 14 On Tue, Dec 19, 2017 at 1:36 PM, Linus Torvalds wrote: > In this case, there's obviously no permission issue: it's an error > report. So it's either "remove it, or switch to %px". Yup, my intention was to kill this %p and enhance the report to actually include the useful information like, "what is the offset from the start of the object", etc. That's what really matters. -Kees -- Kees Cook Pixel Security