Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753997AbdLTAge (ORCPT ); Tue, 19 Dec 2017 19:36:34 -0500 Received: from mail-ot0-f195.google.com ([74.125.82.195]:39649 "EHLO mail-ot0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753762AbdLTAga (ORCPT ); Tue, 19 Dec 2017 19:36:30 -0500 X-Google-Smtp-Source: ACJfBougrHqKFNr5LjTaMR7FunPyTiQRL3GI/jot6hh1G5NM8CJuqnQ0MCNx4GFlxS58TcMBFdrVzg== Subject: Re: [PATCH] tools/power: Don't make man pages executable To: "Rafael J. Wysocki" Cc: Len Brown , linux-kernel@vger.kernel.org References: <20171219195457.1601-1-labbott@redhat.com> <61161aff-c427-0355-e147-9c55445c3184@intel.com> From: Laura Abbott Message-ID: Date: Tue, 19 Dec 2017 16:36:26 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <61161aff-c427-0355-e147-9c55445c3184@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2175 Lines: 53 On 12/19/2017 03:48 PM, Rafael J. Wysocki wrote: > On 12/19/2017 8:54 PM, Laura Abbott wrote: >> rpm-lint flagged these as being executable: >> >> kernel-tools.x86_64: W: spurious-executable-perm /usr/share/man/man8/turbostat.8.gz >> kernel-tools.x86_64: W: spurious-executable-perm /usr/share/man/man8/x86_energy_perf_policy.8.gz >> >> Fix this >> >> Signed-off-by: Laura Abbott > > Please CC PM stuff to linux-pm (which makes it easier to handle). > Neither of these are listed in MAINTAINERS so I missed sending to linux-pm. I'll remember for next time, do you want me to resend for tracking? Thanks, Laura >> --- >>   tools/power/x86/turbostat/Makefile              | 2 +- >>   tools/power/x86/x86_energy_perf_policy/Makefile | 2 +- >>   2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/tools/power/x86/turbostat/Makefile b/tools/power/x86/turbostat/Makefile >> index a9bc914a8fe8..2ab25aa38263 100644 >> --- a/tools/power/x86/turbostat/Makefile >> +++ b/tools/power/x86/turbostat/Makefile >> @@ -25,4 +25,4 @@ install : turbostat >>       install -d  $(DESTDIR)$(PREFIX)/bin >>       install $(BUILD_OUTPUT)/turbostat $(DESTDIR)$(PREFIX)/bin/turbostat >>       install -d  $(DESTDIR)$(PREFIX)/share/man/man8 >> -    install turbostat.8 $(DESTDIR)$(PREFIX)/share/man/man8 >> +    install -m 644 turbostat.8 $(DESTDIR)$(PREFIX)/share/man/man8 >> diff --git a/tools/power/x86/x86_energy_perf_policy/Makefile b/tools/power/x86/x86_energy_perf_policy/Makefile >> index 2447b1bbaacf..f4534fb8b951 100644 >> --- a/tools/power/x86/x86_energy_perf_policy/Makefile >> +++ b/tools/power/x86/x86_energy_perf_policy/Makefile >> @@ -24,5 +24,5 @@ install : x86_energy_perf_policy >>       install -d  $(DESTDIR)$(PREFIX)/bin >>       install $(BUILD_OUTPUT)/x86_energy_perf_policy $(DESTDIR)$(PREFIX)/bin/x86_energy_perf_policy >>       install -d  $(DESTDIR)$(PREFIX)/share/man/man8 >> -    install x86_energy_perf_policy.8 $(DESTDIR)$(PREFIX)/share/man/man8 >> +    install -m 644 x86_energy_perf_policy.8 $(DESTDIR)$(PREFIX)/share/man/man8 > > > Thanks, > > Rafael > >