Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754033AbdLTA44 (ORCPT ); Tue, 19 Dec 2017 19:56:56 -0500 Received: from resqmta-ch2-02v.sys.comcast.net ([69.252.207.34]:38684 "EHLO resqmta-ch2-02v.sys.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753762AbdLTA4x (ORCPT ); Tue, 19 Dec 2017 19:56:53 -0500 Date: Tue, 19 Dec 2017 18:56:51 -0600 (CST) From: Christopher Lameter X-X-Sender: cl@nuc-kabylake To: Rao Shoaib cc: linux-kernel@vger.kernel.org, paulmck@linux.vnet.ibm.com, brouer@redhat.com, linux-mm@kvack.org Subject: Re: [PATCH] kfree_rcu() should use the new kfree_bulk() interface for freeing rcu structures In-Reply-To: Message-ID: References: <1513705948-31072-1-git-send-email-rao.shoaib@oracle.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-CMAE-Envelope: MS4wfJm7IFyiXmoybD65h05UqmGq3RG/QcJReaUcUKMouznQW079iBfwbJPnHg4HyyprIf0mt0yazWhEsXejwSPSPvsWnx+K89rv5NQv6RNMe31HexyWFXH8 m/2kpoTgQBGCREYGyTAueLzuZkRnjX3NrsXoSKxaPsp3Rj3/kS7GOnUyTadSTSMQUTvML8AVIXPZqEqlzat4IVIUjQwCMv8ZtgqEB4hH6Ec0Mj2a9wjcC/lF TvZd+0UK1N5ISCtdF7saLdfHnTvEAryFMfQKuY1svvdvBb/iAH5g/kM2cOsG0xfZ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 661 Lines: 21 On Tue, 19 Dec 2017, Rao Shoaib wrote: > > > mm/slab_common.c > > It would be great to have separate patches so that we can review it > > properly: > > > > 1. Move the code into slab_common.c > > 2. The actual code changes to the kfree rcu mechanism > > 3. The whitespace changes > I can certainly break down the patch and submit smaller patches as you have > suggested. > > BTW -- This is my first ever patch to Linux, so I am still learning the > etiquette. You are doing great. Keep at improving the patches and we will get your changes into the kernel source. If you want to sent your first patchset then a tool like "quilt" or "git" might be helpful.