Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753687AbdLTBSU (ORCPT ); Tue, 19 Dec 2017 20:18:20 -0500 Received: from mail-sn1nam02on0129.outbound.protection.outlook.com ([104.47.36.129]:3616 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751559AbdLTBSQ (ORCPT ); Tue, 19 Dec 2017 20:18:16 -0500 Authentication-Results: spf=pass (sender IP is 117.103.190.43) smtp.mailfrom=sony.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=sony.com; From: "Takiguchi, Yasunari" To: Mauro Carvalho Chehab CC: "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-media@vger.kernel.org" , "tbird20d@gmail.com" , "frowand.list@gmail.com" , "Yamamoto, Masayuki" , "Nozawa, Hideki (STWN)" , "Yonezawa, Kota" , "Matsumoto, Toshihiko" , "Watanabe, Satoshi (SSS)" , "Takiguchi, Yasunari" Subject: RE: [PATCH v4 07/12] [media] cxd2880: Add top level of the driver Thread-Topic: [PATCH v4 07/12] [media] cxd2880: Add top level of the driver Thread-Index: AQHTdEg5DqXzDxyuYEipsC4+zkYfYaNLdRZQ Date: Wed, 20 Dec 2017 01:18:00 +0000 Message-ID: <02699364973B424C83A42A84B04FDA85440BF4@JPYOKXMS113.jp.sony.com> References: <20171013054635.20946-1-Yasunari.Takiguchi@sony.com> <20171013060934.21612-1-Yasunari.Takiguchi@sony.com> <20171213172509.1942e951@vento.lan> In-Reply-To: <20171213172509.1942e951@vento.lan> Accept-Language: ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [2001:cf8:1:aec:0:dddd:19e1:c008] Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:117.103.190.43;IPV:NLI;CTRY:JP;EFV:NLI;SFV:NSPM;SFS:(10019020)(396003)(39860400002)(346002)(376002)(2980300002)(438002)(199004)(189003)(4326008)(16586007)(356003)(54906003)(7696005)(246002)(39060400002)(97756001)(47776003)(2920100001)(2900100001)(305945005)(46406003)(7736002)(107886003)(478600001)(6246003)(106002)(7636002)(72206003)(316002)(2906002)(86362001)(33656002)(55016002)(6116002)(229853002)(5660300001)(8676002)(102836003)(106466001)(76176011)(23726003)(6916009)(8936002)(2950100002)(50466002)(55846006);DIR:OUT;SFP:1102;SCL:1;SRVR:BN6PR1301MB2017;H:jp.sony.com;FPR:;SPF:Pass;PTR:jpyokxeg103.jp.sony.com;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;CY1NAM02FT037;1:kH0UJAWTs3jHJX3Atr/PzX9Vi5uSJFE3JsfkFE24Cv05u/yuGmFrPL2FbhW/lXpecnvpMfb7HhlOw0l0AXwtecLAKhfG4gsMvTf71RH3jmWAva9BSYvVaGNMPEOjnfhO X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6aaea422-315b-4957-8c64-08d5474789be X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(4608076)(2017052603307);SRVR:BN6PR1301MB2017; X-Microsoft-Exchange-Diagnostics: 1;BN6PR1301MB2017;3:JtgfEQ7ccu9gKZP0qK53O8hKDE/K9bR/NDX44z8vOcext2MV9fhzG/Tq43aoVLBvIv7oA36s1rTcEHwhHAHk+59ntzDRDV7NHKgQ0M5CQ4CwkNa2QBJDkmTFHwLdC7wCaDYoTXYcshJaIgHz57LZD1/lfe83bL1+gOLLk9Hot9rQ5TcmcAU/lSdJHHMc28uiwcP/Mhsu6N3PjKpFPWCtagll7kJSoZ5B+lZ3kBGq59f/XAd1JOgua7z20EYqg/VlZLQiGg7ZxNpSyS/Rgasj9Z47qlX3ZA/Dfj2laSwmUjauRKInpPnqcRFHPq9U0m9BsibmH1OfYBAHRdSNBcKxA9DsK+Tius2ON2eHNZ8jZrc=;25:ZeFhhU9GMQKQFWAwkxXaEMlQ3x7XBxD04U861jsZBHqBF1obpsUcMZ90rvKMxdpi+Hp8SMlIQfNhzJsO3Y55cPbTJ/J9wZVuVP+9ZKrIt2xTHWh48nLdaF1TD8aSi1Iu+/BsJ44Cue22BMejv64nUKFtYXX7L4GsuahfgXcLr0bqn3/Xg2rhKiRwwnYohV0lMowrMZYG/QOnnjS/492nWoEFT8AAvuJgC2deosCGeQEFk0mGMnBuKfY0TCh6VfZdY2eU67qqhx5kAxjcALJtEgM2vxNW0eYl4iOlU9IduaoLLmfvSK3cGd0fRyOnKmW20copLxULFeUAfrY890Jasw== X-MS-TrafficTypeDiagnostic: BN6PR1301MB2017: X-Microsoft-Exchange-Diagnostics: 1;BN6PR1301MB2017;31:PUxXpxAaq+/N90KJbapJzhC5M+guVDoHA/u5AIHBzTnfNyyu6jD4/ugz5N9TdocVMwt+jaADHrCmBgvnX8WUnT432A9TTEOqI09FB/z2LWBEncpbnz5Ik6o63DGNWMYlgOQqiAYmfRJcdsoEjIsl6WXJEVDB8JMOJDPAvW0h6mzwYLbYqTHU9yd+1SSKTE5nWU7ZEm04JZ/rIGTGVDEUlMvAj6pcLtObbVhz8o3+Z3w=;20:xkleXCoSD5bV3UfU2ReGQa50sagwnrNtrd/lu2jLQg/Eu358rIUfGI+mGG1GPnppYfS+A2UVcrHXlWGh/HStrC4Sol4mAS7aJdJBeXMwEwH/+pMEryp5z1/3deJDg1FhcdrKAla1iJqEXTB5UDF4Lt+4Gu/IFH7JaBN+Z5v8F3Fm5Nm1vVVmLULzzjh3JuA3w+Qu3w6fQjd8wLEzxtxDpo7xsJN01rhHG3twqnyIlgtr1Rt45+i9+admLHmFsYiFgSPOyHPx6ag7Bii/z00+IleMwnEnA9wdQ8cG4tGSGT6i/dqG7+YXj6BM3JJUXpbOK+49MW7/ZEEV9NAwY8CC42mPGp4Mu0JNuEAjzotHQuS1ygZIhC7unOV+3KPMb52+d1zFenQZMzE25JZ4EtxQTdEncKVZZwe+nm2Ac1owT+RJROyhGTlL5Ceg16PCVt9byGvWStcVn2cxR6dYqLoOHBlQjaLdkxGPvPDQTqsG6ewgmz/RZFAwGBG7G/EXe5Yk X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(2401047)(5005006)(8121501046)(93006095)(93004095)(10201501046)(3231023)(11241501184)(3002001)(6055026)(6041248)(20161123560044)(20161123558119)(20161123562044)(201703131423075)(201702281528075)(20161123555044)(201703061421075)(201703061406153)(20161123564044)(6072148)(201708071742011);SRVR:BN6PR1301MB2017;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:BN6PR1301MB2017; X-Microsoft-Exchange-Diagnostics: 1;BN6PR1301MB2017;4:w/MNFC4fAsaJIedzEGz1mPDaNgVCh+60jXxbePfcCds0dP3rW9ZZmDHve/WRmFjcGGbpYeAVDM9qNLl+51ApbzNUer4Hgr7wJHIiSyEHtwsCkd2iW7fNswHxIQxRliyLp50gOUdxRyrzt0QJG4znjfhWOVn1jWlxyydDWHwzMAk4QdVNxkLD/6BjKrWCrQYZ2117acMq1wN0oAWcsR7qkJtKpSUF9N/ZH84i4+z2lArAJSMwEUQuMN0vflmd5zdbvggBVpPpkyMvqSy1n9ssVQ== X-Forefront-PRVS: 0527DFA348 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BN6PR1301MB2017;23:nhKu9xBESby4PGQ4VY2NJ+TYkWaLnkdZoGbS5qh?= =?us-ascii?Q?B3uPBpNgb94gIqFCOB73bXix9bzMerdtYqeuZOWNpsRXk68j1gA0WpdGfJn7?= =?us-ascii?Q?DbT6QqQQYDva6r9XTVxf5EY5gxoe8KpmQK0D7p9ltB+JN+FsHULduvNjx28U?= =?us-ascii?Q?oSj7V39hH58OK6V0FvSrGZj0oM+FZwGtrYiTCMpHOKKwxjkEOmy0fHuK68UG?= =?us-ascii?Q?D07TZPX2iO1dLkrRhV3/tsZgjVFFLvELhMZdEAV+oEdyxqMq6/m8VH5eiNPf?= =?us-ascii?Q?o56WOtxWCK+NqlvuOTkm39jtdpYnRnlvMWkvs5pY4s+U4f9+OTLOe7CqVhVn?= =?us-ascii?Q?xYBnZ1Rs+R0HCTCl8y+qoEbQc0kdm1UE7dhn+zgizCtBThbds17Vri54Bu6X?= =?us-ascii?Q?HVjFXmEKFSiKA4UonC4EaxRfk5PYdijDkzfoNReNhCSUsBVrNMETivtFNvVS?= =?us-ascii?Q?+pLEWF3eme6NHuPlmqnlT9wdrY/B5N2YT9jB/8YU6enZDyN4vlgKqkS4AuNm?= =?us-ascii?Q?fz/Jm6TO94i2D64bxkhOYYsJtPme4sMS4hjvc7qomULHwIS/uj+uU1X6Tge+?= =?us-ascii?Q?XuTAOl2DZOQM3EDY4zIfYikSVg22FPBl8SIa9kwRJpcHbUonFX5MSIjKdgZ5?= =?us-ascii?Q?HIK3JbZCSZe5kDPoCWKNlJ/CwMXGdfWywySIquL1+ocCZhcXX5xr++YeylX6?= =?us-ascii?Q?0PY2I6l34pKWZmtUrzDlMTwMvg+ADEO2VcGbaCCGajF5i5aPzXxxShnp07y4?= =?us-ascii?Q?oN5XJbpcMUc7ttA8HuWY0VlT+bJDImQu8iENhxUMiQGXTiSi0uOliW2NSfn3?= =?us-ascii?Q?LrKAfHv7cLPICklLZYvuwgYZ0vOX2WhaA+bcxtyNoTGrhk7MxJ67hhDPV86k?= =?us-ascii?Q?mhJ2HSjR/USDYFmWskjQueqnWoHFB+wkj6378Po8t+/CgKYTdD+8JQMKIpml?= =?us-ascii?Q?W7aQ3zUurp0y1edIHJQ2YfnpSP6OweHIy3JLPEEd1orw8+oxIh9Fym++JVk8?= =?us-ascii?Q?S7Nw+xz62971VL1xRUWtuTn/m8uGH4lUetJue93YlS0hhY1otDn2kBCI34BE?= =?us-ascii?Q?7lsROPHAQ0QdX6QB3DyoBURDp7kq+?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR1301MB2017;6:jvU1oRZ6xLNMm9wpYB+lMHfgdNCYed/KzoaTsor1xi6wIN1ZquBhK4ExIvijcPJvvfDK7zKiWimsioUEveUUrWOJ4p7/G56pSSYSr5tteaH1/GWvabOJQxw6FVosshOfh3oKMVTiA6PlK2o8Pwx+VGb7//mzVWrR+pO/hog8EVXxXh+bS5fEr7xN9hbGALL2ZKgstNfbJMWaiCMMjEjpiJwLnKTqL0tjRN3WfFzBb2Un1N7k+rwFeHAuuhCQ8CFC3utUmy0yPz1KPxhusC+mmZe+/ccuq4paAJ4zRtdoBwG/ebWX4y4gn8Zn9ckFe9w6MO2xVEiomC6c8TNH0cQnq+NAjQLTzoujG24JwiLdgl8=;5:Du2EZ9dD0H0TTmU5aCxNB5lkMgypnOSg4j9JOaYeh1+MAm4Qs08DWh56SIcvhZPwcwv1MUyfW37SHamma6zn6lc22KRk0rEFE6LflVhQnvGtUJlenhHvQbOPUtY2td1B2vz7KuoG5lTbeGSASoI9qRR4swP8Q8o+FxXQy9QvnLI=;24:gAbHwTdydHR9C2qH+r7Sf4RBn7lJbqugGb1d5MWtjuCa/XuC+myfo2kwVFXcAerMqpoZv10EuwlQksif99rt+J+kWlTAMo3/5jIbmSHVsjo=;7:8TkY1q4Z85yaTpIc0lLo6Dd+BzXHKbM6wYVymCRvhaUeoOWChxJLo4fgUIkhTPTlJYMzyI7+vjFv5Vx0EIxnndwl8LebTPSSx84ELJXzPs8mPsmA5NLq/2vbpl02sjj2e5xsCFyKX1avkoFCSxf0HZC/3NwJj6RjkvfyyWppVNWnHqGc7axfK1PyxjL84v/jm6sNlV3wWEe7M1LHySpJWQptNYAOg4IxQODIcU0ukUC2qgjsMgzSvlmxnwDovQn9 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: sony.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2017 01:18:11.6853 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6aaea422-315b-4957-8c64-08d5474789be X-MS-Exchange-CrossTenant-Id: 66c65d8a-9158-4521-a2d8-664963db48e4 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=66c65d8a-9158-4521-a2d8-664963db48e4;Ip=[117.103.190.43];Helo=[jp.sony.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1301MB2017 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 354 Lines: 13 Hi, Mauro > > + > > +#define pr_fmt(fmt) KBUILD_MODNAME ": %s: " fmt, __func__ > > Same comments as on other patches: use SPDX and dev_foo() for printing > messages. About printing messages pr_fmt, I also replied a comment to [PATCH v4 02/12] [media] cxd2880-spi: Add support for CXD2880 SPI interface. Please refer to the comment. Thanks, Takiguchi