Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753349AbdLTBdp convert rfc822-to-8bit (ORCPT ); Tue, 19 Dec 2017 20:33:45 -0500 Received: from cmccmta3.chinamobile.com ([221.176.66.81]:19310 "EHLO cmccmta3.chinamobile.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751820AbdLTBdn (ORCPT ); Tue, 19 Dec 2017 20:33:43 -0500 X-RM-TRANSID: 2eea5a39bdf0147-97082 X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 X-RM-TRANSID: 2ee45a39bdf29f6-64e6a Content-Type: text/plain; charset=gb2312 Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: [PATCH v2,net-next 1/2] ip_gre: fix potential memory leak in erspan_rcv From: Haishuang Yan In-Reply-To: <20171219.103633.721139612524381957.davem@davemloft.net> Date: Wed, 20 Dec 2017 09:33:38 +0800 Cc: kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, u9012063@gmail.com Content-Transfer-Encoding: 8BIT Message-Id: <59C91D21-77BA-4A26-9E8D-9275A269EDE9@cmss.chinamobile.com> References: <1513392519-30127-1-git-send-email-yanhaishuang@cmss.chinamobile.com> <20171219.103633.721139612524381957.davem@davemloft.net> To: David Miller X-Mailer: Apple Mail (2.3273) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 730 Lines: 25 > On 2017??12??19??, at ????11:36, David Miller wrote: > > From: Haishuang Yan > Date: Sat, 16 Dec 2017 10:48:38 +0800 > >> If md is NULL, tun_dst must be freed, otherwise it will cause memory >> leak. >> >> Fixes: 1a66a836da6 ("gre: add collect_md mode to ERSPAN tunnel") >> Cc: William Tu >> Signed-off-by: Haishuang Yan >> >> Change since v2: >> * Rebase on latest master branch. >> * Correct wrong fix information. > > Please do not put a changelog after the fixes and signoff tags, those tags must > appear last in the commit message. > > Thank you. > Okay, I will resubmit another commit, thanks.