Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753971AbdLTBgH (ORCPT ); Tue, 19 Dec 2017 20:36:07 -0500 Received: from mga02.intel.com ([134.134.136.20]:43846 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753839AbdLTBgF (ORCPT ); Tue, 19 Dec 2017 20:36:05 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,429,1508828400"; d="scan'208";a="13744395" Subject: Re: [PATCH] tools/power: Don't make man pages executable To: Laura Abbott Cc: Len Brown , linux-kernel@vger.kernel.org References: <20171219195457.1601-1-labbott@redhat.com> <61161aff-c427-0355-e147-9c55445c3184@intel.com> From: "Rafael J. Wysocki" Organization: Intel Technology Poland Sp. z o. o., KRS 101882, ul. Slowackiego 173, 80-298 Gdansk Message-ID: Date: Wed, 20 Dec 2017 02:36:03 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2326 Lines: 68 On 12/20/2017 1:36 AM, Laura Abbott wrote: > On 12/19/2017 03:48 PM, Rafael J. Wysocki wrote: >> On 12/19/2017 8:54 PM, Laura Abbott wrote: >>> rpm-lint flagged these as being executable: >>> >>> kernel-tools.x86_64: W: spurious-executable-perm >>> /usr/share/man/man8/turbostat.8.gz >>> kernel-tools.x86_64: W: spurious-executable-perm >>> /usr/share/man/man8/x86_energy_perf_policy.8.gz >>> >>> Fix this >>> >>> Signed-off-by: Laura Abbott >> >> Please CC PM stuff to linux-pm (which makes it easier to handle). >> > > Neither of these are listed in MAINTAINERS so I missed sending to > linux-pm. I'll remember for next time, do you want me to resend > for tracking? > Yes, please. Thanks, Rafael > >>> --- >>>   tools/power/x86/turbostat/Makefile              | 2 +- >>>   tools/power/x86/x86_energy_perf_policy/Makefile | 2 +- >>>   2 files changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/tools/power/x86/turbostat/Makefile >>> b/tools/power/x86/turbostat/Makefile >>> index a9bc914a8fe8..2ab25aa38263 100644 >>> --- a/tools/power/x86/turbostat/Makefile >>> +++ b/tools/power/x86/turbostat/Makefile >>> @@ -25,4 +25,4 @@ install : turbostat >>>       install -d  $(DESTDIR)$(PREFIX)/bin >>>       install $(BUILD_OUTPUT)/turbostat >>> $(DESTDIR)$(PREFIX)/bin/turbostat >>>       install -d  $(DESTDIR)$(PREFIX)/share/man/man8 >>> -    install turbostat.8 $(DESTDIR)$(PREFIX)/share/man/man8 >>> +    install -m 644 turbostat.8 $(DESTDIR)$(PREFIX)/share/man/man8 >>> diff --git a/tools/power/x86/x86_energy_perf_policy/Makefile >>> b/tools/power/x86/x86_energy_perf_policy/Makefile >>> index 2447b1bbaacf..f4534fb8b951 100644 >>> --- a/tools/power/x86/x86_energy_perf_policy/Makefile >>> +++ b/tools/power/x86/x86_energy_perf_policy/Makefile >>> @@ -24,5 +24,5 @@ install : x86_energy_perf_policy >>>       install -d  $(DESTDIR)$(PREFIX)/bin >>>       install $(BUILD_OUTPUT)/x86_energy_perf_policy >>> $(DESTDIR)$(PREFIX)/bin/x86_energy_perf_policy >>>       install -d  $(DESTDIR)$(PREFIX)/share/man/man8 >>> -    install x86_energy_perf_policy.8 >>> $(DESTDIR)$(PREFIX)/share/man/man8 >>> +    install -m 644 x86_energy_perf_policy.8 >>> $(DESTDIR)$(PREFIX)/share/man/man8 >> >> >> Thanks, >> >> Rafael >> >> >