Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754124AbdLTChV (ORCPT ); Tue, 19 Dec 2017 21:37:21 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:59978 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753323AbdLTChR (ORCPT ); Tue, 19 Dec 2017 21:37:17 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org C0DCE60B0E Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=vivek.gautam@codeaurora.org X-Google-Smtp-Source: ACJfBosrY0DKi5IHTaJKntBBjXv3Z8d/5rey7kgNdo7ivdMJMTfPZppB5foXSt7RASqne1JdRQwq1zIptCXR3iEWlAM= MIME-Version: 1.0 In-Reply-To: <1511256206-1587-3-git-send-email-mgautam@codeaurora.org> References: <1511256206-1587-1-git-send-email-mgautam@codeaurora.org> <1511256206-1587-3-git-send-email-mgautam@codeaurora.org> From: Vivek Gautam Date: Wed, 20 Dec 2017 08:07:14 +0530 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 02/16] phy: qcom-qmp: Adapt to clk_bulk_* APIs To: Manu Gautam Cc: Kishon Vijay Abraham I , linux-arm-msm , Linux USB Mailing List , Varadarajan Narayanan , Wei Yongjun , Fengguang Wu , "open list:GENERIC PHY FRAMEWORK" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2191 Lines: 65 Hi Manu, On Tue, Nov 21, 2017 at 2:53 PM, Manu Gautam wrote: > From: Vivek Gautam > > Move from using array of clocks to clk_bulk_* APIs that > are available now. > > Signed-off-by: Vivek Gautam > Signed-off-by: Manu Gautam > --- > drivers/phy/qualcomm/phy-qcom-qmp.c | 50 ++++++++++++------------------------- > 1 file changed, 16 insertions(+), 34 deletions(-) > > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c > index 76acaec..90794dd 100644 > --- a/drivers/phy/qualcomm/phy-qcom-qmp.c > +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c [snip] > @@ -998,29 +992,17 @@ static int qcom_qmp_phy_reset_init(struct device *dev) > static int qcom_qmp_phy_clk_init(struct device *dev) > { > struct qcom_qmp *qmp = dev_get_drvdata(dev); > - int ret, i; > + int num = qmp->cfg->num_clks; > + int i; > > - qmp->clks = devm_kcalloc(dev, qmp->cfg->num_clks, > - sizeof(*qmp->clks), GFP_KERNEL); > + qmp->clks = devm_kcalloc(dev, num, sizeof(*qmp->clks), GFP_KERNEL); > if (!qmp->clks) > return -ENOMEM; > > - for (i = 0; i < qmp->cfg->num_clks; i++) { > - struct clk *_clk; > - const char *name = qmp->cfg->clk_list[i]; > - > - _clk = devm_clk_get(dev, name); > - if (IS_ERR(_clk)) { > - ret = PTR_ERR(_clk); > - if (ret != -EPROBE_DEFER) > - dev_err(dev, "failed to get %s clk, %d\n", > - name, ret); > - return ret; > - } > - qmp->clks[i] = _clk; > - } > + for (i = 0; i < num; i++) > + qmp->clks->id = qmp->cfg->clk_list[i]; I think i missed this one while rebasing. We need to use index with this. Should be: qmp->clks[i]->id = qmp->cfg->clk_list[i]; Regards Vivek -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation