Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754008AbdLTDV7 (ORCPT <rfc822;w@1wt.eu>);
        Tue, 19 Dec 2017 22:21:59 -0500
Received: from mail-lf0-f66.google.com ([209.85.215.66]:35514 "EHLO
        mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752630AbdLTDV5 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 19 Dec 2017 22:21:57 -0500
X-Google-Smtp-Source: ACJfBotTFsb8fxDhazEzIOpVbv9boButNS2t/552sLX0zglL+Bw7G59EwJBT+VsP1mlFXH+j4cchliIU19hx15j9iZE=
MIME-Version: 1.0
In-Reply-To: <c5ef27de-34c1-f5e9-e4ae-e2709b004677@kaod.org>
References: <20171215062443.23059-1-joel@jms.id.au> <20171215062443.23059-11-joel@jms.id.au>
 <c5ef27de-34c1-f5e9-e4ae-e2709b004677@kaod.org>
From: Joel Stanley <joel@jms.id.au>
Date: Wed, 20 Dec 2017 13:51:34 +1030
X-Google-Sender-Auth: J7MPgVy7LfPyIeFVVp_TDpXb4jE
Message-ID: <CACPK8Xd2e=wDD7udyH9-mMuxXsRjCj8LDsosp=5b3e0iTJwA5A@mail.gmail.com>
Subject: Re: [PATCH v2 10/19] ARM: dts: aspeed: Add LPC Snoop device
To: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= <clg@kaod.org>
Cc: Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
        Arnd Bergmann <arnd@arndb.de>, Andrew Jeffery <andrew@aj.id.au>,
        Patrick Venture <venture@google.com>, Xo Wang <xow@google.com>,
        Lei YU <mine260309@gmail.com>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Jeremy Kerr <jk@ozlabs.org>, devicetree <devicetree@vger.kernel.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-aspeed@lists.ozlabs.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id vBK3M34i008826
Content-Length: 1069
Lines: 35

On Mon, Dec 18, 2017 at 7:46 PM, Cédric Le Goater <clg@kaod.org> wrote:
> On 12/15/2017 07:24 AM, Joel Stanley wrote:
>> LPC snoop hardware on the ASPEED BMC, used for monitoring
>> host I/O port activity.
>>
>> Signed-off-by: Joel Stanley <joel@jms.id.au>
>> ---
>>  arch/arm/boot/dts/aspeed-g4.dtsi | 7 +++++++
>>  arch/arm/boot/dts/aspeed-g5.dtsi | 6 ++++++
>>  2 files changed, 13 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi b/arch/arm/boot/dts/aspeed-g4.dtsi
>> index f6fee40c04c0..b3580f37f507 100644
>> --- a/arch/arm/boot/dts/aspeed-g4.dtsi
>> +++ b/arch/arm/boot/dts/aspeed-g4.dtsi
>> @@ -236,6 +236,13 @@
>>                                               status = "disabled";
>>                                       };
>>
>> +                                     lpc_snoop: lpc-snoop@0 {
>> +                                             compatible = "aspeed,ast2500-lpc-snoop";
>
> it should be :
>
>         aspeed,ast2400-lpc-snoop
>
> a part from that :
>
> Reviewed-by: Cédric Le Goater <clg@kaod.org>

Fixed in v3.

Cheers,

Joel