Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754161AbdLTDXB (ORCPT <rfc822;w@1wt.eu>);
        Tue, 19 Dec 2017 22:23:01 -0500
Received: from mail-lf0-f49.google.com ([209.85.215.49]:37356 "EHLO
        mail-lf0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753449AbdLTDW6 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 19 Dec 2017 22:22:58 -0500
X-Google-Smtp-Source: ACJfBotsjV76pm1I4/rJkOGtPhquxWxieMtU5tIm8adRDem9EwQSvqUYCwt3Sfy8WyjhFqLFQj4ZyP+1miZYf7ZdBWk=
MIME-Version: 1.0
In-Reply-To: <b8e80861-88c4-da87-a201-ca2eefaa5a94@kaod.org>
References: <20171215062443.23059-1-joel@jms.id.au> <20171215062443.23059-19-joel@jms.id.au>
 <b8e80861-88c4-da87-a201-ca2eefaa5a94@kaod.org>
From: Joel Stanley <joel@jms.id.au>
Date: Wed, 20 Dec 2017 13:52:36 +1030
X-Google-Sender-Auth: dh9uXY-mJgcUqVjT4Pkf-wnivo4
Message-ID: <CACPK8Xdb59ofAnpGt6Uoe9AubTirzvU1=R-4k2y0mfjz09YAjQ@mail.gmail.com>
Subject: Re: [PATCH v2 18/19] ARM: dts: aspeed-romulus: Update Romulus system
To: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= <clg@kaod.org>
Cc: Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
        Arnd Bergmann <arnd@arndb.de>, Andrew Jeffery <andrew@aj.id.au>,
        Patrick Venture <venture@google.com>, Xo Wang <xow@google.com>,
        Lei YU <mine260309@gmail.com>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Jeremy Kerr <jk@ozlabs.org>, devicetree <devicetree@vger.kernel.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-aspeed@lists.ozlabs.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id vBK3N5wB008934
Content-Length: 942
Lines: 45

On Mon, Dec 18, 2017 at 8:02 PM, Cédric Le Goater <clg@kaod.org> wrote:
>> +};
>> +
>> +&fmc {
>> +     status = "okay";
>> +
>> +     flash@0 {
>> +             status = "okay";
>> +             label = "pnor";
>> +             m25p,fast-read;
>> +#include "openbmc-flash-layout.dtsi"
>> +     };
>> +};
>> +
>> +&spi1 {
>> +     status = "okay";
>> +
>> +     pinctrl-names = "default";
>> +     pinctrl-0 = <&pinctrl_spi1_default>;
>> +
>> +     flash@0 {
>> +             status = "okay";
>> +             label = "pnor";
>> +             m25p,fast-read;
>>       };
>>  };
>
>
> hmm, the fmc and spi1 bindings were already added in commit 1142aea9ff9d.
>
>
>> @@ -38,6 +101,7 @@
>>               status = "okay";
>>               m25p,fast-read;
>>               label = "bmc";
>> +#include "openbmc-flash-layout.dtsi"
>
>
> This looks like an extra "fmc" node ?

You're right. It still built and booted too. Good catch.

Cheers,

Joel