Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753621AbdLTGP2 (ORCPT ); Wed, 20 Dec 2017 01:15:28 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:47089 "EHLO huawei.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751978AbdLTGPY (ORCPT ); Wed, 20 Dec 2017 01:15:24 -0500 Subject: Re: [PATCH V2 net-next 01/17] net: hns3: add support to query tqps number To: David Miller References: <1513656159-127589-1-git-send-email-lipeng321@huawei.com> <1513656159-127589-2-git-send-email-lipeng321@huawei.com> <20171219.141644.1574828912135603880.davem@davemloft.net> CC: , , , From: "lipeng (Y)" Message-ID: <3df115cc-1b66-b05a-d222-eb4f1d24879d@huawei.com> Date: Wed, 20 Dec 2017 14:14:58 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20171219.141644.1574828912135603880.davem@davemloft.net> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.63.173.108] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 669 Lines: 23 On 2017/12/20 3:16, David Miller wrote: > From: Lipeng > Date: Tue, 19 Dec 2017 12:02:23 +0800 > >> @@ -5002,6 +5002,26 @@ static void hclge_uninit_ae_dev(struct hnae3_ae_dev *ae_dev) >> ae_dev->priv = NULL; >> } >> >> +static u32 hclge_get_max_channels(struct hnae3_handle *handle) >> +{ >> + struct hclge_vport *vport = hclge_get_vport(handle); >> + struct hnae3_knic_private_info *kinfo = &handle->kinfo; >> + struct hclge_dev *hdev = vport->back; >> + > Please order local variables from longest to shortest line. > > Please audit your entire submission for this problem. > > . will check this patch-set about this problem. Thanks