Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932359AbdLTGuD (ORCPT ); Wed, 20 Dec 2017 01:50:03 -0500 Received: from mail-pg0-f50.google.com ([74.125.83.50]:43415 "EHLO mail-pg0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932272AbdLTGuA (ORCPT ); Wed, 20 Dec 2017 01:50:00 -0500 X-Google-Smtp-Source: ACJfBounl+7cc1BMrC3vP76ziNEI3UJGRH3IWlKNaXqgXTGDZiS64TaEwRAreD++iRUzGgodoPwQLw== Date: Wed, 20 Dec 2017 00:49:57 -0600 From: Andy Gross To: Mathieu Malaterre Cc: Rob Herring , Wei Xu , Mark Rutland , Catalin Marinas , Will Deacon , Matthias Brugger , David Brown , Kees Cook , Anton Vorontsov , Colin Cross , Tony Luck , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org Subject: Re: [PATCH] arm64: dts: Remove leading 0x and 0s from bindings notation Message-ID: <20171220064957.GA17982@hector.attlocal.net> References: <20171214165352.27902-1-malat@debian.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171214165352.27902-1-malat@debian.org> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1198 Lines: 29 On Thu, Dec 14, 2017 at 05:53:52PM +0100, Mathieu Malaterre wrote: > Improve the DTS files by removing all the leading "0x" and zeros to fix the > following dtc warnings: > > Warning (unit_address_format): Node /XXX unit name should not have leading "0x" > > and > > Warning (unit_address_format): Node /XXX unit name should not have leading 0s > > Converted using the following command: > > find . -type f \( -iname *.dts -o -iname *.dtsi \) -exec sed -E -i -e "s/@0x([0-9a-fA-F\.]+)\s?\{/@\L\1 \{/g" -e "s/@0+([0-9a-fA-F\.]+)\s?\{/@\L\1 \{/g" {} + > > For simplicity, two sed expressions were used to solve each warnings separately. > > To make the regex expression more robust a few other issues were resolved, > namely setting unit-address to lower case, and adding a whitespace before the > the opening curly brace: > > https://elinux.org/Device_Tree_Linux#Linux_conventions > > This is a follow up to commit 4c9847b7375a ("dt-bindings: Remove leading 0x from bindings notation") > > Reported-by: David Daney > Suggested-by: Rob Herring > Signed-off-by: Mathieu Malaterre Acked-by: Andy Gross