Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754575AbdLTJcP (ORCPT ); Wed, 20 Dec 2017 04:32:15 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:34930 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753269AbdLTJcL (ORCPT ); Wed, 20 Dec 2017 04:32:11 -0500 Date: Wed, 20 Dec 2017 10:32:11 +0100 From: Greg Kroah-Hartman To: Joe Perches Cc: Jarkko Nikula , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Cezary Jackiewicz , Darren Hart , Andy Shevchenko , Sebastian Ott , Peter Oberparleiter , James Smart , Dick Kennedy , Zhang Rui , Eduardo Valentin , Mathias Nyman , Felipe Balbi , "Luis R. Rodriguez" , Peter Ujfalusi , Martin Schwidefsky , Heiko Carstens , David Airlie , "James E.J. Bottomley" , "Martin K. Petersen" , Jiri Slaby , Bartlomiej Zolnierkiewicz , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, platform-driver-x86@vger.kernel.org, linux-scsi@vger.kernel.org, linux-pm@vger.kernel.org, linux-serial@vger.kernel.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, alsa-devel@alsa-project.org, linux-omap@vger.kernel.org Subject: Re: [-next PATCH 2/4] treewide: Use DEVICE_ATTR_RW Message-ID: <20171220093211.GA16177@kroah.com> References: <20171220083403.GA27231@bitmer.com> <1513761884.1234.83.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1513761884.1234.83.camel@perches.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1832 Lines: 48 On Wed, Dec 20, 2017 at 01:24:44AM -0800, Joe Perches wrote: > On Wed, 2017-12-20 at 10:34 +0200, Jarkko Nikula wrote: > > On Tue, Dec 19, 2017 at 10:15:07AM -0800, Joe Perches wrote: > > > Convert DEVICE_ATTR uses to DEVICE_ATTR_RW where possible. > [] > > > diff --git a/sound/soc/omap/mcbsp.c b/sound/soc/omap/mcbsp.c > [] > > > @@ -854,7 +854,7 @@ static ssize_t dma_op_mode_store(struct device *dev, > > > return size; > > > } > > > > > > -static DEVICE_ATTR(dma_op_mode, 0644, dma_op_mode_show, dma_op_mode_store); > > > +static DEVICE_ATTR_RW(dma_op_mode); > > > > > > > While I can ack this part here if it helps generic cleanup effort I > > don't understart would it improve code readability in general? Mode 644 > > is clear and don't need any grepping but for DEVICE_ATTR_RW() I had to go > > through all of these files in order to see what does it mean: Yeah, 644 is "clear", but _RW() is even more clear. Ideally I want to get rid of all of the "non-standard" users that set random modes of sysfs files, as we get it wrong too many times. Using the "defaults" is much better. > Are you suggesting that device.h (as that is where > DEVICE_ATTR and the other DEVICE_ATTR_ variants > are #defined) should have better comments for the > _ variants? > > > DEVICE_ATTR_RW: include/linux/device.h > > __ATTR_RW: include/linux/sysfs.h > > S_IWUSR: include/uapi/linux/stat.h > > S_IRUGO: include/linux/stat.h > > btw: patch 1/4 of the series does remove the uses of > S_ from these macros in sysfs.h and converts > them to simple octal instead. Why you didn't send that patch to the sysfs maintainer is a bit odd... :) I should be taking this whole series through my tree. Joe, thanks for doing this in an automated way, I've been wanting to see this done for a long time. thanks, greg k-h