Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755026AbdLTKfQ (ORCPT ); Wed, 20 Dec 2017 05:35:16 -0500 Received: from mail-vk0-f66.google.com ([209.85.213.66]:35745 "EHLO mail-vk0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754153AbdLTKfL (ORCPT ); Wed, 20 Dec 2017 05:35:11 -0500 X-Google-Smtp-Source: ACJfBotUibRIaus3FeWdHV8Bla1s8cCEZI5FLD1msSTe6iM+aS5XLcUBOz82qwR8RxNcyf1BpHA/sPLLJ7jcWyWSZzQ= MIME-Version: 1.0 In-Reply-To: References: <95be78502aa406f106ecbe87e751a45333883b1f.1513577007.git.green.hu@gmail.com> <201712201744.gsBDa4yK%fengguang.wu@intel.com> From: Greentime Hu Date: Wed, 20 Dec 2017 18:34:29 +0800 Message-ID: Subject: Re: [PATCH v4 33/36] net: faraday add nds32 support. To: Geert Uytterhoeven Cc: kbuild test robot , kbuild-all@01.org, Greentime , Linux Kernel Mailing List , Arnd Bergmann , Linux-Arch , Thomas Gleixner , Jason Cooper , Marc Zyngier , Rob Herring , netdev , Vincent Chen , DTML , Al Viro , David Howells , Will Deacon , Daniel Lezcano , linux-serial@vger.kernel.org, Linus Walleij , Mark Rutland , Greg KH , Guo Ren , Philippe Ombredanne Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2586 Lines: 68 2017-12-20 17:58 GMT+08:00 Geert Uytterhoeven : > On Wed, Dec 20, 2017 at 10:54 AM, kbuild test robot wrote: >> I love your patch! Perhaps something to improve: >> >> [auto build test WARNING on tip/timers/core] >> [cannot apply to linus/master v4.15-rc4 next-20171220] >> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] >> >> url: https://github.com/0day-ci/linux/commits/Greentime-Hu/Andes-nds32-Linux-Kernel/20171220-155937 >> config: sparc64-allyesconfig (attached as .config) >> compiler: sparc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 >> reproduce: >> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross >> chmod +x ~/bin/make.cross >> # save the attached .config to linux build tree >> make.cross ARCH=sparc64 >> >> All warnings (new ones prefixed by >>): >> >> drivers/net/ethernet/faraday/ftmac100.c: In function 'ftmac100_rxdes_set_page': >>>> drivers/net/ethernet/faraday/ftmac100.c:288:18: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] >> rxdes->rxdes3 = (unsigned int)page; >> ^ > > The proper way to casts pointer to integers is to cast to "uintptr_t". > > However, the address is stored in a 32-bit descriptor, which means it can > not work on 64-bit platforms. > > Please make the driver depend on "!64BIT || BROKEN" > > Cfr. commit 15bfe05c8d6386f1 ("net: ethernet: xilinx: Mark XILINX_LL_TEMAC > broken on 64-bit") > Thanks Geert. I will apply it like this. +++ b/drivers/net/ethernet/faraday/Kconfig @@ -5,7 +5,7 @@ config NET_VENDOR_FARADAY bool "Faraday devices" default y - depends on ARM + depends on ARM || NDS32 || COMPILE_TEST ---help--- If you have a network (Ethernet) card belonging to this class, say Y. @@ -18,7 +18,8 @@ if NET_VENDOR_FARADAY config FTMAC100 tristate "Faraday FTMAC100 10/100 Ethernet support" - depends on ARM + depends on ARM || NDS32 || COMPILE_TEST + depends on !64BIT || BROKEN select MII ---help--- This driver supports the FTMAC100 10/100 Ethernet controller @@ -27,7 +28,8 @@ config FTMAC100 config FTGMAC100 tristate "Faraday FTGMAC100 Gigabit Ethernet support" - depends on ARM + depends on ARM || NDS32 || COMPILE_TEST + depends on !64BIT || BROKEN select PHYLIB ---help--- This driver supports the FTGMAC100 Gigabit Ethernet controller