Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754932AbdLTKmE (ORCPT ); Wed, 20 Dec 2017 05:42:04 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:48966 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754404AbdLTKmB (ORCPT ); Wed, 20 Dec 2017 05:42:01 -0500 Date: Wed, 20 Dec 2017 11:42:03 +0100 From: Greg KH To: Laurentiu Tudor Cc: Ruxandra Ioana Radulescu , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" , Bogdan Purcareata , Leo Li , "stuyoder@gmail.com" , Roy Pledge , "andrew@lunn.ch" , "linux-arm-kernel@lists.infradead.org" , Stuart Yoder , Thomas Gleixner , Jason Cooper , Marc Zyngier Subject: Re: [PATCH v4] staging: fsl-mc: move bus driver out of staging Message-ID: <20171220104203.GA29824@kroah.com> References: <20171129100844.19874-1-laurentiu.tudor@nxp.com> <20171219144802.GA4534@kroah.com> <5A392E3A.6040303@nxp.com> <20171219152916.GA11279@kroah.com> <5A3932BF.80106@nxp.com> <20171219161045.GA18839@kroah.com> <5A3A3AE6.6080905@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5A3A3AE6.6080905@nxp.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 778 Lines: 21 On Wed, Dec 20, 2017 at 10:26:49AM +0000, Laurentiu Tudor wrote: > On 12/19/2017 06:10 PM, Greg KH wrote: > >>> But all of these .h files are only used by the code in this specific > >>> directory, no where else. > >> > >> They are also used by our ethernet driver, see: > >> drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h > > > > Ick, really? Then they should not be buried in a bus-specific > > location, but rather be in include/linux/SOMEWHERE, right? > > Right. The goal is that in the end, all headers be moved to the already > existing include/linux/fsl/. For now I've left these in staging because > they are not part of the bus "core" infrastructure. Then shouldn't they be in the drivers/staging/fsl-mc/include/ directory now to show this? thanks, greg k-h