Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754829AbdLTKxA (ORCPT ); Wed, 20 Dec 2017 05:53:00 -0500 Received: from mail-he1eur01on0046.outbound.protection.outlook.com ([104.47.0.46]:15562 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753874AbdLTKw4 (ORCPT ); Wed, 20 Dec 2017 05:52:56 -0500 From: Laurentiu Tudor To: Greg KH CC: Ruxandra Ioana Radulescu , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" , "Bogdan Purcareata" , Leo Li , "stuyoder@gmail.com" , Roy Pledge , "andrew@lunn.ch" , "linux-arm-kernel@lists.infradead.org" , Stuart Yoder , Thomas Gleixner , Jason Cooper , Marc Zyngier Subject: Re: [PATCH v4] staging: fsl-mc: move bus driver out of staging Thread-Topic: [PATCH v4] staging: fsl-mc: move bus driver out of staging Thread-Index: AQHTaPoaqtNRHeNsCUOhGxRQkBuH+KNK3skAgAAJDQCAAAJ4AIAAAuuAgAAIrICAATI5AIAABEWAgAADBYA= Date: Wed, 20 Dec 2017 10:52:52 +0000 Message-ID: <5A3A4103.6050502@nxp.com> References: <20171129100844.19874-1-laurentiu.tudor@nxp.com> <20171219144802.GA4534@kroah.com> <5A392E3A.6040303@nxp.com> <20171219152916.GA11279@kroah.com> <5A3932BF.80106@nxp.com> <20171219161045.GA18839@kroah.com> <5A3A3AE6.6080905@nxp.com> <20171220104203.GA29824@kroah.com> In-Reply-To: <20171220104203.GA29824@kroah.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=laurentiu.tudor@nxp.com; x-originating-ip: [86.34.165.90] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;VI1PR0401MB1709;6:hMwu8Fk97/5TMLh6dHBkiY3LzfC6aswGZvkRGwBQK21zz2OhzFTaOROSewu8rP/6NfgADKY7htaI0aWVZts0fSMkYeLAVWwA5F5OUM50Tv3qUWgftBQMIosxJD574saYw3bBE/XWum5UFMlPnL0RE5O/qYmXsee5d7E6qmVHDtRqeBjgPznVcTofK5Myj03wQ1OQtLHWJV9yqMwQ8tiw65PW6EWijkCv9qoa/JqZVh24086p+fA8fYwLOx7NjEaHAXeo/B3+wo8Z7pkOfmadO8booB5lnkQkB9XwIqrKx2feHfV2ZQqmg8dcaAmXqbBhS0GI0fbKGZJy6JtsJrMGPjp55mbUvRr8rGw8pBuJeyI=;5:FdUod4F8hA+bwRkhyBdotKoU1wPRlp6u1sNcfa2Kw7LRrrOv3/6Rh0AFkOYCoF0CF1qosmQqV2UdmuHiMeKE5N4No/Xy2ocoN0askJrvlkPJ+KXI/AWNNh6HSW4/EMedGqayNC1/dUrTaxOG323Pj5XohVaEJzZ8qI3KG36ArjA=;24:oQxW8QAxecFjtgwARUVRaH8OLcqLq6bUEczd38TTTPmaZpaabd3pfomqbzAIRjD9y3o9tdcN4/kopuZggkr0T2q9rUUwaTfdXL7hjbQVmbc=;7:Vc8wSabztLYh/Y8y03jXGSeUEMr5ivnbHEJJ+YMIv+rpVjx9LRedjz1f+54eaqrEf8FyRzeXGizl6F/o7CvVY5V3X+avKz0+yxChb01b4Io4aEFlErqAtWFJcK4UboMDCBZezLinaOQZGGZE7pt1AOIZDT4bGu3UoUlBgZvduESSvFXRuY764/Bt8c3spaqqWFh+NsT/yBIagA4eInU23UYGRf8EuNzKSztdM/Z6TAPvUwVX9/Jrq2l2m4vLGBMf x-ms-exchange-antispam-srfa-diagnostics: SSOS;SSOR; x-forefront-antispam-report: SFV:SKI;SCL:-1;SFV:NSPM;SFS:(10009020)(346002)(39860400002)(376002)(396003)(366004)(39380400002)(51344004)(24454002)(199004)(189003)(7736002)(6246003)(478600001)(102836003)(5250100002)(66066001)(4326008)(25786009)(6436002)(2900100001)(93886005)(54906003)(53936002)(39060400002)(229853002)(80316001)(6116002)(8936002)(3846002)(105586002)(316002)(36756003)(6512007)(3280700002)(81166006)(33656002)(68736007)(99286004)(87266011)(2906002)(76176011)(6486002)(65816011)(106356001)(3660700001)(5660300001)(8676002)(81156014)(2950100002)(6916009)(305945005)(53546011)(14454004)(97736004)(59896002)(6506007)(86362001);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0401MB1709;H:VI1PR0401MB1856.eurprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 7d787faf-ffb5-4979-96e9-08d54797d196 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(48565401081)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060);SRVR:VI1PR0401MB1709; x-ms-traffictypediagnostic: VI1PR0401MB1709: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040470)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(3231023)(6055026)(6041268)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(6072148)(201708071742011);SRVR:VI1PR0401MB1709;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:VI1PR0401MB1709; x-forefront-prvs: 0527DFA348 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="Windows-1252" Content-ID: MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7d787faf-ffb5-4979-96e9-08d54797d196 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Dec 2017 10:52:52.1609 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB1709 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id vBKArFLa015643 Content-Length: 1081 Lines: 30 On 12/20/2017 12:42 PM, Greg KH wrote: > On Wed, Dec 20, 2017 at 10:26:49AM +0000, Laurentiu Tudor wrote: >> On 12/19/2017 06:10 PM, Greg KH wrote: >>>>> But all of these .h files are only used by the code in this specific >>>>> directory, no where else. >>>> >>>> They are also used by our ethernet driver, see: >>>> drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h >>> >>> Ick, really? Then they should not be buried in a bus-specific >>> location, but rather be in include/linux/SOMEWHERE, right? >> >> Right. The goal is that in the end, all headers be moved to the already >> existing include/linux/fsl/. For now I've left these in staging because >> they are not part of the bus "core" infrastructure. > > Then shouldn't they be in the drivers/staging/fsl-mc/include/ directory > now to show this? Not sure i get your comment. Aren't we talking about the headers in there? This was your original comment: > Also, what's up with the .h files in drivers/staging/fsl-bus/include? > You didn't touch those with this movement, right? Why? --- Best Regards, Laurentiu