Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755064AbdLTLfv (ORCPT ); Wed, 20 Dec 2017 06:35:51 -0500 Received: from mail-wr0-f193.google.com ([209.85.128.193]:36603 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754857AbdLTLfr (ORCPT ); Wed, 20 Dec 2017 06:35:47 -0500 X-Google-Smtp-Source: ACJfBovz5Jauw+lnEZ+pR29EjKs3IcHEsKo+P9tt9xwraKM+h+bJxUkY9aaasXWUjVjD7CMWaV4KiQ== From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: James Ettle , Hans de Goede , Azhar Shaikh , Javier Martinez Canillas , Arnd Bergmann , Jarkko Sakkinen , Peter Huewe , Jason Gunthorpe , Greg Kroah-Hartman , linux-integrity@vger.kernel.org Subject: [PATCH 0/4] tpm: fix PS/2 devices not working on Braswell systems due CLKRUN enabled Date: Wed, 20 Dec 2017 12:35:34 +0100 Message-Id: <20171220113538.16099-1-javierm@redhat.com> X-Mailer: git-send-email 2.14.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1599 Lines: 45 Hello, Commit 5e572cab92f0 ("tpm: Enable CLKRUN protocol for Braswell systems") added logic in the TPM TIS driver to disable the Low Pin Count CLKRUN signal during TPM transactions. Unfortunately this breaks other devices that are attached to the LPC bus like for example PS/2 mouse and keyboards. The bug was reported to the Fedora kernel [0] and the kernel bugzilla [1]. This issue and the propossed solution were discussed in this [2] thread, and the reporter (Jame Ettle) confirmed that his system works again after the fix in this series. The patches are based on top or Jarkko Sakkinen's linux-tpmdd [3] tree. James, Even when there shouldn't be any functional changes, I included some other fixes / cleanups in this series so it would be great if you can test them again. I can't because I don't have access to a machine affected by this. [0]: https://bugzilla.redhat.com/show_bug.cgi?id=1498987 [1]: https://bugzilla.kernel.org/show_bug.cgi?id=197287 [2]: https://patchwork.kernel.org/patch/10119417/ [3]: git.infradead.org/users/jjs/linux-tpmdd.git Best regards, Javier Javier Martinez Canillas (4): tpm: fix access attempt to an already unmapped I/O memory region tpm: delete the TPM_TIS_CLK_ENABLE flag tpm: follow coding style for variable declaration in tpm_tis_core_init() tpm: only attempt to disable the LPC CLKRUN if is already enabled drivers/char/tpm/tpm_tis.c | 17 +---------------- drivers/char/tpm/tpm_tis_core.c | 24 +++++++++++++++++------- drivers/char/tpm/tpm_tis_core.h | 1 - 3 files changed, 18 insertions(+), 24 deletions(-) -- 2.14.3