From: Laurentiu Tudor <laurentiu.tudor@nxp.com>
To: Greg KH <gregkh@linuxfoundation.org>
CC: Ruxandra Ioana Radulescu <ruxandra.radulescu@nxp.com>,
        "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Bogdan Purcareata" <bogdan.purcareata@nxp.com>,
        Leo Li <leoyang.li@nxp.com>, "stuyoder@gmail.com" <stuyoder@gmail.com>,
        Roy Pledge <roy.pledge@nxp.com>, "andrew@lunn.ch" <andrew@lunn.ch>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        Stuart Yoder <stuart.yoder@nxp.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Jason Cooper <jason@lakedaemon.net>,
        Marc Zyngier <marc.zyngier@arm.com>
Subject: Re: [PATCH v4] staging: fsl-mc: move bus driver out of staging
Thread-Topic: [PATCH v4] staging: fsl-mc: move bus driver out of staging
Thread-Index: AQHTaPoaqtNRHeNsCUOhGxRQkBuH+KNK3skAgAAJDQCAAAJ4AIAAAuuAgAAIrICAATI5AIAABEWAgAADBYCAAAPdgIAADM6A
Date: Wed, 20 Dec 2017 11:52:32 +0000
Message-ID: <5A3A4EFF.6050901@nxp.com>
References: <20171129100844.19874-1-laurentiu.tudor@nxp.com>
 <20171219144802.GA4534@kroah.com> <5A392E3A.6040303@nxp.com>
 <20171219152916.GA11279@kroah.com> <5A3932BF.80106@nxp.com>
 <20171219161045.GA18839@kroah.com> <5A3A3AE6.6080905@nxp.com>
 <20171220104203.GA29824@kroah.com> <5A3A4103.6050502@nxp.com>
 <20171220110641.GB7001@kroah.com>
In-Reply-To: <20171220110641.GB7001@kroah.com>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="Windows-1252"
Content-ID: <DE26163B3F73C041AD8BDC2BD9602F31@eurprd04.prod.outlook.com>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 5e99af4a-ae2f-42ff-406a-08d547a02779
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Dec 2017 11:52:32.4140
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB1709
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id vBKBqmRO025080
Content-Length: 1433
Lines: 39


On 12/20/2017 01:06 PM, Greg KH wrote:
> On Wed, Dec 20, 2017 at 10:52:52AM +0000, Laurentiu Tudor wrote:
>>
>>
>> On 12/20/2017 12:42 PM, Greg KH wrote:
>>> On Wed, Dec 20, 2017 at 10:26:49AM +0000, Laurentiu Tudor wrote:
>>>> On 12/19/2017 06:10 PM, Greg KH wrote:
>>>>>>> But all of these .h files are only used by the code in this specific
>>>>>>> directory, no where else.
>>>>>>
>>>>>> They are also used by our ethernet driver, see:
>>>>>>       drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h
>>>>>
>>>>> Ick, really?  Then they should not be buried in a bus-specific
>>>>> location, but rather be in include/linux/SOMEWHERE, right?
>>>>
>>>> Right. The goal is that in the end, all headers be moved to the already
>>>> existing include/linux/fsl/. For now I've left these in staging because
>>>> they are not part of the bus "core" infrastructure.
>>>
>>> Then shouldn't they be in the drivers/staging/fsl-mc/include/ directory
>>> now to show this?
>>
>> Not sure i get your comment. Aren't we talking about the headers in there?
>>
>> This was your original comment:
>>
>>   > Also, what's up with the .h files in drivers/staging/fsl-bus/include?
>>   > You didn't touch those with this movement, right?  Why?
>
> Ok, yeah, I'm getting confused now.  Let's just see what you do with
> your next set of patches and we can go from there :)

Ok, I'll start working on it. Thanks for the review!

---
Best Regards, Laurentiu