Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755584AbdLTQg0 (ORCPT ); Wed, 20 Dec 2017 11:36:26 -0500 Received: from eddie.linux-mips.org ([148.251.95.138]:44598 "EHLO cvs.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755350AbdLTQgZ (ORCPT ); Wed, 20 Dec 2017 11:36:25 -0500 Date: Wed, 20 Dec 2017 17:36:16 +0100 From: Ralf Baechle To: Jiaxun Yang Cc: James Hogan , linux-mips@linux-mips.org, Huacai Chan , linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 1/5] MIPS: Lonngson64: Copy kernel command line from arcs_cmdline Message-ID: <20171220163616.GH28538@linux-mips.org> References: <20171216145751.3486-1-jiaxun.yang@flygoat.com> <20171216145751.3486-2-jiaxun.yang@flygoat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171216145751.3486-2-jiaxun.yang@flygoat.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 568 Lines: 17 On Sat, Dec 16, 2017 at 10:57:47PM +0800, Jiaxun Yang wrote: > Since lemote-2f/marchtype.c need to get cmdline from loongson.h > this patch simply copy kernel command line from arcs_cmdline > to fix that issue Sorry, I don't quite understand. Is the issue that arcs_cmdline[] is declared as __initdata in arch/mips/kernel/setup.c? Note that it's ok to use arcs_cmdline on a non-ARCS machine. ARC systems were the first systems supported by Linux/MIPS, that's how the variable got its name; the name was just never properly cleaned up but probably should. Ralf