MIME-Version: 1.0
In-Reply-To: <CAGngYiVJRVuMtLThnvsXbXMuL-_4ZN=2RkuCkRBzq3cf+W4sPg@mail.gmail.com>
References: <1513621702-6565-1-git-send-email-svenv@arcx.com>
 <1513621702-6565-2-git-send-email-svenv@arcx.com> <CAMRc=Md0VwJ=OeE_-2uWi2sr4gJ8v9CnmexYgdDGR0pbyXYo_g@mail.gmail.com>
 <CAGngYiVJRVuMtLThnvsXbXMuL-_4ZN=2RkuCkRBzq3cf+W4sPg@mail.gmail.com>
From: Bartosz Golaszewski <brgl@bgdev.pl>
Date: Wed, 20 Dec 2017 17:37:51 +0100
Message-ID: <CAMRc=McQThGRYqmbue8jw_uKQPicitQn6rNxZxo9+HYQ3UaYDw@mail.gmail.com>
Subject: Re: [PATCH v3 1/1] eeprom: at24: convert magic numbers to structs.
To: Sven Van Asbroeck <thesven73@gmail.com>
Cc: Sven Van Asbroeck <svenv@arcx.com>,
        Sven Van Asbroeck <svendev@arcx.com>, Wolfram Sang <wsa@the-dreams.de>,
        nsekhar@ti.com, Sakari Ailus <sakari.ailus@linux.intel.com>,
        Javier Martinez Canillas <javier@dowhile0.org>,
        Divagar Mohandass <divagar.mohandass@intel.com>,
        devicetree <devicetree@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-i2c <linux-i2c@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 520
Lines: 14

2017-12-20 17:32 GMT+01:00 Sven Van Asbroeck <thesven73@gmail.com>:
>>> +       { .compatible = "atmel,24c00", .data = &at24_data_24c00 },
>>
>> Add tabs here as well, seems like there's enough space in the line.
>
> There's not enough space in the line to line up the 24c1024 entry with
> the others. I'll revert to the formatting style that was there before.

I'm at 77 columns if I add a single tab after '.compatible = "atmel,24c1024"'.

It looks nice like this, so I prefer to keep it.

Thanks,
Bartosz Golaszewski