Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756180AbdLTSxR (ORCPT ); Wed, 20 Dec 2017 13:53:17 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:42246 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755774AbdLTSxM (ORCPT ); Wed, 20 Dec 2017 13:53:12 -0500 Date: Wed, 20 Dec 2017 13:53:05 -0500 (EST) Message-Id: <20171220.135305.1152270786921147796.davem@davemloft.net> To: yanhaishuang@cmss.chinamobile.com Cc: kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, u9012063@gmail.com Subject: Re: [PATCH v3,net-next 2/2] ip6_gre: fix error path when ip6erspan_rcv failed From: David Miller In-Reply-To: <1513736507-22968-3-git-send-email-yanhaishuang@cmss.chinamobile.com> References: <1513736507-22968-1-git-send-email-yanhaishuang@cmss.chinamobile.com> <1513736507-22968-3-git-send-email-yanhaishuang@cmss.chinamobile.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 20 Dec 2017 10:53:11 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 469 Lines: 12 From: Haishuang Yan Date: Wed, 20 Dec 2017 10:21:47 +0800 > Same as ipv4 code, when ip6erspan_rcv call return PACKET_REJECT, we > should call icmpv6_send to send icmp unreachable message in error path. > > Fixes: 5a963eb61b7c ("ip6_gre: Add ERSPAN native tunnel support") > Acked-by: William Tu > Cc: William Tu > Signed-off-by: Haishuang Yan Applied.