Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756167AbdLTSzI (ORCPT ); Wed, 20 Dec 2017 13:55:08 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:42165 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755941AbdLTSzE (ORCPT ); Wed, 20 Dec 2017 13:55:04 -0500 X-Google-Smtp-Source: ACJfBov+kj35Cu7iAu/eCRq+zN9U3j+wyt3LBDqaftTF1x0RFeQUZP/qPedXcRa2Bc2iQ6SBFr5jgA== Date: Wed, 20 Dec 2017 11:54:58 -0700 From: Jason Gunthorpe To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, James Ettle , Hans de Goede , Azhar Shaikh , Arnd Bergmann , Jarkko Sakkinen , Peter Huewe , Greg Kroah-Hartman , linux-integrity@vger.kernel.org Subject: Re: [PATCH 1/4] tpm: fix access attempt to an already unmapped I/O memory region Message-ID: <20171220185458.GE22908@ziepe.ca> References: <20171220113538.16099-1-javierm@redhat.com> <20171220113538.16099-2-javierm@redhat.com> <20171220180855.GB22908@ziepe.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 525 Lines: 16 On Wed, Dec 20, 2017 at 07:21:31PM +0100, Javier Martinez Canillas wrote: > > The below draft fixes everything except #1. That needs a more thoughtful > > idea.. > > > > I'll just drop this patch from the series and you can fix all the issues in > the error / driver removal paths. It's not a dependency anyways, I included > it just because noticed the issue while reading the code. Azhar, this means it becomes your problem :) Since the patches Jarkko has queued from you introduce oops's you need to fix them.. Jason