Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756384AbdLTTaP (ORCPT ); Wed, 20 Dec 2017 14:30:15 -0500 Received: from smtprelay.synopsys.com ([198.182.60.111]:44206 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755920AbdLTTaM (ORCPT ); Wed, 20 Dec 2017 14:30:12 -0500 Subject: Re: [PATCH v6 04/18] PCI: designware-ep: Pre-allocate memory for MSI in dw_pcie_ep_init To: Niklas Cassel , Jingoo Han , Joao Pinto , Lorenzo Pieralisi , Bjorn Helgaas CC: Niklas Cassel , , References: <20171219232940.659-1-niklas.cassel@axis.com> <20171219232940.659-5-niklas.cassel@axis.com> From: Joao Pinto Message-ID: <690a6c50-f5af-24bb-2f49-ba828022dcee@synopsys.com> Date: Wed, 20 Dec 2017 19:30:06 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20171219232940.659-5-niklas.cassel@axis.com> Content-Type: text/plain; charset="utf-8" Content-Language: pt-PT Content-Transfer-Encoding: 8bit X-Originating-IP: [10.107.15.23] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2033 Lines: 64 Hi, Às 11:29 PM de 12/19/2017, Niklas Cassel escreveu: > Certain SoCs need to map the MSI address in raise_irq. > To map an address, you first need to call pci_epc_mem_alloc_addr(), > however, pci_epc_mem_alloc_addr() calls ioremap() (which can sleep). > > Since raise_irq is only called from atomic context, we can't call > pci_epc_mem_alloc_addr() from raise_irq. > > Pre-allocate a page in dw_pcie_ep_init(), so that this page can later > be used to map/unmap the MSI address in raise_irq. > > Signed-off-by: Niklas Cassel > --- > drivers/pci/dwc/pcie-designware-ep.c | 10 ++++++++++ > drivers/pci/dwc/pcie-designware.h | 2 ++ > 2 files changed, 12 insertions(+) > > diff --git a/drivers/pci/dwc/pcie-designware-ep.c b/drivers/pci/dwc/pcie-designware-ep.c > index 3fb34be99715..8d8019cdff2a 100644 > --- a/drivers/pci/dwc/pcie-designware-ep.c > +++ b/drivers/pci/dwc/pcie-designware-ep.c > @@ -286,6 +286,9 @@ void dw_pcie_ep_exit(struct dw_pcie_ep *ep) > { > struct pci_epc *epc = ep->epc; > > + pci_epc_mem_free_addr(epc, ep->msi_mem_phys, ep->msi_mem, > + epc->mem->page_size); > + > pci_epc_mem_exit(epc); > } > > @@ -341,6 +344,13 @@ int dw_pcie_ep_init(struct dw_pcie_ep *ep) > return ret; > } > > + ep->msi_mem = pci_epc_mem_alloc_addr(epc, &ep->msi_mem_phys, > + epc->mem->page_size); > + if (!ep->msi_mem) { > + dev_err(dev, "Failed to reserve memory for MSI\n"); > + return -ENOMEM; > + } > + > ep->epc = epc; > epc_set_drvdata(epc, ep); > dw_pcie_setup(pci); > diff --git a/drivers/pci/dwc/pcie-designware.h b/drivers/pci/dwc/pcie-designware.h > index 9aaf0cd04dd6..5a1da459eda5 100644 > --- a/drivers/pci/dwc/pcie-designware.h > +++ b/drivers/pci/dwc/pcie-designware.h > @@ -198,6 +198,8 @@ struct dw_pcie_ep { > unsigned long ob_window_map; > u32 num_ib_windows; > u32 num_ob_windows; > + void __iomem *msi_mem; > + phys_addr_t msi_mem_phys; > }; > > struct dw_pcie_ops { > Acked-by: Joao Pinto