Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756418AbdLTVv6 (ORCPT ); Wed, 20 Dec 2017 16:51:58 -0500 Received: from mail-wr0-f195.google.com ([209.85.128.195]:43976 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755494AbdLTVvy (ORCPT ); Wed, 20 Dec 2017 16:51:54 -0500 X-Google-Smtp-Source: ACJfBosXJ6yAxCER1Mwc+HYN1WnYmUOGgyLekG/8qZBALPtRezUVrRJGDm/Nj4nB58zhMP8QBDXRktNzs+K07OhVxEg= MIME-Version: 1.0 In-Reply-To: <20171220204517.28313-1-andrew.smirnov@gmail.com> References: <20171220204517.28313-1-andrew.smirnov@gmail.com> From: Philippe Ombredanne Date: Wed, 20 Dec 2017 22:51:12 +0100 Message-ID: Subject: Re: [PATCH v16 0/5] ZII RAVE platform driver To: Andrey Smirnov Cc: Lee Jones , Pavel Machek , Greg Kroah-Hartman , cphealy@gmail.com, Andy Shevchenko , Lucas Stach , Nikita Yushchenko , Guenter Roeck , Rob Herring , Mark Rutland , Johan Hovold , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML , Sebastian Reichel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1436 Lines: 49 Andrey, On Wed, Dec 20, 2017 at 9:45 PM, Andrey Smirnov wrote: > Everyone: > > This patch series is v16 of the driver for supervisory processor found > on RAVE series of devices from ZII. Supervisory processor is a PIC > microcontroller connected to various electrical subsystems on RAVE > devices whose firmware implements protocol to command/qery them. > > NOTE: > > * This driver dependends on crc_ccitt_false(), added by > 2da9378d531f8cc6670c7497f20d936b706ab80b in 'linux-next', the patch > was pulled in by Andrew Morton and is currently avaiting users, so > this series might have to go in through Andrew's tree > > Changes since [v15]: > > - Adopted SPDX tags for licensing information per Philippe's > request Thank you for using the SPDX tags: you have my cheerful ack for the SPDX tags for the whole patch set There is one minor problem though: your comment style for the SPDX tag lines. Check Thomas doc patches and Linus comments on this topic: you should use // C++ style commnent in .c files and /* */ C-style comments in .h files. e.g. do not use this for a .c file: > +++ b/drivers/watchdog/rave-sp-wdt.c > @@ -0,0 +1,337 @@ > +/* SPDX-License-Identifier: GPL-2.0+ */ But this instead: > +++ b/drivers/watchdog/rave-sp-wdt.c > @@ -0,0 +1,337 @@ > +// SPDX-License-Identifier: GPL-2.0+ Acked-by: Philippe Ombredanne -- Cordially Philippe