Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756633AbdLUAIK (ORCPT ); Wed, 20 Dec 2017 19:08:10 -0500 Received: from mail-qk0-f172.google.com ([209.85.220.172]:39431 "EHLO mail-qk0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755711AbdLUAIJ (ORCPT ); Wed, 20 Dec 2017 19:08:09 -0500 X-Google-Smtp-Source: ACJfBosRBvHI4x51KSDlCyD720scx2oleAoiX6Q7Y+DD669lsmFpWdsRjy6pHjVi2PIbi+EYN9Ps9Q== Date: Wed, 20 Dec 2017 16:08:05 -0800 From: "tj@kernel.org" To: Bart Van Assche Cc: "axboe@kernel.dk" , "kernel-team@fb.com" , "linux-kernel@vger.kernel.org" , "peterz@infradead.org" , "osandov@fb.com" , "linux-block@vger.kernel.org" , "oleg@redhat.com" , "hch@lst.de" Subject: Re: [PATCHSET v2] blk-mq: reimplement timeout handling Message-ID: <20171221000805.GC1084507@devbig577.frc2.facebook.com> References: <20171212190134.535941-1-tj@kernel.org> <1513813261.2603.36.camel@wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1513813261.2603.36.camel@wdc.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 674 Lines: 21 On Wed, Dec 20, 2017 at 11:41:02PM +0000, Bart Van Assche wrote: > On Tue, 2017-12-12 at 11:01 -0800, Tejun Heo wrote: > > Currently, blk-mq timeout path synchronizes against the usual > > issue/completion path using a complex scheme involving atomic > > bitflags, REQ_ATOM_*, memory barriers and subtle memory coherence > > rules. Unfortunatley, it contains quite a few holes. > > Hello Tejun, > > An attempt to run SCSI I/O with this patch series applied resulted in > the following: Can you please try the v3? There were a couple bugs that I missed while testing earlier versions. http://lkml.kernel.org/r/20171216120726.517153-1-tj@kernel.org Thanks. -- tejun