MIME-Version: 1.0
In-Reply-To: <CAOFm3uHLT5R6SLYpRApFOOh4_=qrhc234EKfk1n-_3AGzgN9RA@mail.gmail.com>
References: <20171220204517.28313-1-andrew.smirnov@gmail.com> <CAOFm3uHLT5R6SLYpRApFOOh4_=qrhc234EKfk1n-_3AGzgN9RA@mail.gmail.com>
From: Andrey Smirnov <andrew.smirnov@gmail.com>
Date: Wed, 20 Dec 2017 16:20:18 -0800
Message-ID: <CAHQ1cqHwz2V=tGvE=TLh71vGZeo7SvtTkH0+oOefoqRVxUAfRQ@mail.gmail.com>
Subject: Re: [PATCH v16 0/5] ZII RAVE platform driver
To: Philippe Ombredanne <pombredanne@nexb.com>
Cc: Lee Jones <lee.jones@linaro.org>, Pavel Machek <pavel@ucw.cz>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Chris Healy <cphealy@gmail.com>,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        Lucas Stach <l.stach@pengutronix.de>,
        Nikita Yushchenko <nikita.yoush@cogentembedded.com>,
        Guenter Roeck <linux@roeck-us.net>, Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>, Johan Hovold <johan@kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1619
Lines: 53

On Wed, Dec 20, 2017 at 1:51 PM, Philippe Ombredanne
<pombredanne@nexb.com> wrote:
> Andrey,
>
> On Wed, Dec 20, 2017 at 9:45 PM, Andrey Smirnov
> <andrew.smirnov@gmail.com> wrote:
>> Everyone:
>>
>> This patch series is v16 of the driver for supervisory processor found
>> on RAVE series of devices from ZII. Supervisory processor is a PIC
>> microcontroller connected to various electrical subsystems on RAVE
>> devices whose firmware implements protocol to command/qery them.
>>
>> NOTE:
>>
>>  * This driver dependends on crc_ccitt_false(), added by
>>    2da9378d531f8cc6670c7497f20d936b706ab80b in 'linux-next', the patch
>>    was pulled in by Andrew Morton and is currently avaiting users, so
>>    this series might have to go in through Andrew's tree
>>
>> Changes since [v15]:
>>
>>     - Adopted SPDX tags for licensing information per Philippe's
>>       request
>
> Thank you for using the SPDX tags: you have my cheerful ack for the
> SPDX tags for the whole patch set
>
> There is one minor problem though: your comment style for the SPDX tag
> lines. Check Thomas doc patches and Linus comments on this topic: you
> should use // C++ style commnent in .c files and /* */ C-style
> comments in .h files.
>
> e.g. do not use this for a .c file:
>
>> +++ b/drivers/watchdog/rave-sp-wdt.c
>> @@ -0,0 +1,337 @@
>> +/* SPDX-License-Identifier: GPL-2.0+ */
>
> But this instead:
>
>> +++ b/drivers/watchdog/rave-sp-wdt.c
>> @@ -0,0 +1,337 @@
>> +// SPDX-License-Identifier: GPL-2.0+
>
>
> Acked-by: Philippe Ombredanne <pombredanne@nexB.com>
>

OK, good to know, will fix in v17 soon.

Thanks,
Andrey Smirnov