Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756905AbdLUAab (ORCPT ); Wed, 20 Dec 2017 19:30:31 -0500 Received: from gate.crashing.org ([63.228.1.57]:36820 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756543AbdLUAa2 (ORCPT ); Wed, 20 Dec 2017 19:30:28 -0500 Message-ID: <1513810153.2743.25.camel@kernel.crashing.org> Subject: Re: [PATCH v9 29/51] mm/mprotect, powerpc/mm/pkeys, x86/mm/pkeys: Add sysfs interface From: Benjamin Herrenschmidt To: Ram Pai Cc: Dave Hansen , mpe@ellerman.id.au, mingo@redhat.com, akpm@linux-foundation.org, corbet@lwn.net, arnd@arndb.de, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, x86@kernel.org, linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, paulus@samba.org, khandual@linux.vnet.ibm.com, aneesh.kumar@linux.vnet.ibm.com, bsingharora@gmail.com, hbabu@us.ibm.com, mhocko@kernel.org, bauerman@linux.vnet.ibm.com, ebiederm@xmission.com Date: Thu, 21 Dec 2017 09:49:13 +1100 In-Reply-To: <20171220175022.GB5619@ram.oc3035372033.ibm.com> References: <1509958663-18737-1-git-send-email-linuxram@us.ibm.com> <1509958663-18737-30-git-send-email-linuxram@us.ibm.com> <20171218221850.GD5461@ram.oc3035372033.ibm.com> <1513719296.2743.12.camel@kernel.crashing.org> <20171220175022.GB5619@ram.oc3035372033.ibm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.2 (3.26.2-1.fc27) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 683 Lines: 19 On Wed, 2017-12-20 at 09:50 -0800, Ram Pai wrote: > The argument against this patch is -- it should not be baked into > the ABI as yet, since we do not have clarity on what applications need. > > As it stands today the only way to figure out the information from > userspace is by probing the kernel through calls to sys_pkey_alloc(). > > AT_HWCAP can be used, but that will certainly not be capable of > providing all the information that userspace might expect. > > Your thoughts? Well, there's one well known application wanting that whole keys business, so why not ask them what works for them ? In the meantime, that shouldn't block the rest of the patches. Cheers, Ben.