Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756715AbdLUBAy (ORCPT ); Wed, 20 Dec 2017 20:00:54 -0500 Received: from esa1.hgst.iphmx.com ([68.232.141.245]:52819 "EHLO esa1.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755824AbdLUBAv (ORCPT ); Wed, 20 Dec 2017 20:00:51 -0500 X-IronPort-AV: E=Sophos;i="5.45,434,1508774400"; d="scan'208";a="168673655" From: Bart Van Assche To: "tj@kernel.org" CC: "linux-kernel@vger.kernel.org" , "peterz@infradead.org" , "linux-block@vger.kernel.org" , "kernel-team@fb.com" , "oleg@redhat.com" , "hch@lst.de" , "axboe@kernel.dk" , "osandov@fb.com" Subject: Re: [PATCHSET v2] blk-mq: reimplement timeout handling Thread-Topic: [PATCHSET v2] blk-mq: reimplement timeout handling Thread-Index: AQHTc3vvt0xfyoBJfkyq1vSApEyj9qNM8QSAgAAHkICAAA64AA== Date: Thu, 21 Dec 2017 01:00:47 +0000 Message-ID: <1513818046.2603.39.camel@wdc.com> References: <20171212190134.535941-1-tj@kernel.org> <1513813261.2603.36.camel@wdc.com> <20171221000805.GC1084507@devbig577.frc2.facebook.com> In-Reply-To: <20171221000805.GC1084507@devbig577.frc2.facebook.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Bart.VanAssche@wdc.com; x-originating-ip: [199.255.44.250] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CY1PR0401MB1536;20:hZZd8ot/qv9lWvTtLWnsImFPVUfy3kePZ02AA+mZsckqif9jDlIFe+OmPd0Ui+uXbGEVp6/jzAeoadMmdoKEstNUXUg9/HCnWw/bkb0rueiCn5zCDkdxW/OwZJyP4XnPNIzfo3FlnZccp5CP5o+LD1BAhXQ5Wg5/ZVR4doTnXq0= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 79fc0483-59e6-4c94-f987-08d5480e457c x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(2017052603307)(7153060);SRVR:CY1PR0401MB1536; x-ms-traffictypediagnostic: CY1PR0401MB1536: wdcipoutbound: EOP-TRUE x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(42068640409301); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040470)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(3231023)(6055026)(6041268)(20161123558120)(20161123564045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(6072148)(201708071742011);SRVR:CY1PR0401MB1536;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:CY1PR0401MB1536; x-forefront-prvs: 0528942FD8 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(346002)(39860400002)(39380400002)(396003)(366004)(376002)(377424004)(199004)(189003)(24454002)(103116003)(3660700001)(81166006)(66066001)(68736007)(8936002)(229853002)(966005)(102836004)(6486002)(86362001)(6246003)(7736002)(72206003)(4326008)(53936002)(77096006)(14454004)(8676002)(6512007)(6306002)(25786009)(1730700003)(36756003)(81156014)(478600001)(6916009)(2900100001)(305945005)(6116002)(6506007)(5640700003)(76176011)(2906002)(316002)(3280700002)(2950100002)(54906003)(4001150100001)(97736004)(99286004)(2501003)(3846002)(5660300001)(106356001)(105586002)(6436002)(2351001);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR0401MB1536;H:CY1PR0401MB1536.namprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <46C7DF1D0ABEFA44849B76B235563336@namprd04.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: 79fc0483-59e6-4c94-f987-08d5480e457c X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Dec 2017 01:00:47.4103 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0401MB1536 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id vBL10wlL000502 Content-Length: 984 Lines: 23 On Wed, 2017-12-20 at 16:08 -0800, tj@kernel.org wrote: > On Wed, Dec 20, 2017 at 11:41:02PM +0000, Bart Van Assche wrote: > > On Tue, 2017-12-12 at 11:01 -0800, Tejun Heo wrote: > > > Currently, blk-mq timeout path synchronizes against the usual > > > issue/completion path using a complex scheme involving atomic > > > bitflags, REQ_ATOM_*, memory barriers and subtle memory coherence > > > rules. Unfortunatley, it contains quite a few holes. > > > > Hello Tejun, > > > > An attempt to run SCSI I/O with this patch series applied resulted in > > the following: > > Can you please try the v3? There were a couple bugs that I missed > while testing earlier versions. > > http://lkml.kernel.org/r/20171216120726.517153-1-tj@kernel.org Will do. But please Cc: linux-block in case you would post a v4 of this patch series. I searched the linux-block folder of my mailbox for the latest version of this patch series and that is how I ended up testing v2 instead of v3 ... Bart.