Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752016AbdLUJH5 (ORCPT ); Thu, 21 Dec 2017 04:07:57 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51934 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751542AbdLUJHt (ORCPT ); Thu, 21 Dec 2017 04:07:49 -0500 Subject: Re: [PATCH linux-next] KVM: x86: don't forget vcpu_put() in kvm_arch_vcpu_ioctl_set_sregs() To: Lan Tianyu , Eric Biggers , kvm@vger.kernel.org Cc: rkrcmar@redhat.com, christoffer.dall@linaro.org, x86@kernel.org, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com, Eric Biggers , Stephen Rothwell , Linux-Next Mailing List References: <001a1148cc3acf967c0560c7b760@google.com> <20171221002427.82325-1-ebiggers3@gmail.com> <5e98adf7-809f-3b98-e8fc-6ba89e2777cf@redhat.com> <1bed30da-d01f-ecfd-8024-d7c402c30f15@intel.com> From: Paolo Bonzini Message-ID: Date: Thu, 21 Dec 2017 10:07:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <1bed30da-d01f-ecfd-8024-d7c402c30f15@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 21 Dec 2017 09:07:49 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 356 Lines: 10 On 21/12/2017 03:45, Lan Tianyu wrote: > Hi Paolo: > Should we check input sregs before loading vcpu? If input sregs is > invalid, the operation is redundant. That would be another way to fix the conflict. Note that the conflict is between two different trees (kvm/master and kvm/next), so in any case it will remain until the next merge window. Paolo