Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751892AbdLUJN0 (ORCPT ); Thu, 21 Dec 2017 04:13:26 -0500 Received: from mga01.intel.com ([192.55.52.88]:51048 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751071AbdLUJNV (ORCPT ); Thu, 21 Dec 2017 04:13:21 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,435,1508828400"; d="scan'208";a="15444120" Subject: Re: [PATCH 07/12] mmc: sdhci_omap: Fix sdhci-omap quirks To: Kishon Vijay Abraham I , Ulf Hansson , Rob Herring , Tony Lindgren Cc: Mark Rutland , Russell King , linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, nsekhar@ti.com References: <20171214130941.26666-1-kishon@ti.com> <20171214130941.26666-8-kishon@ti.com> From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: Date: Thu, 21 Dec 2017 11:12:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171214130941.26666-8-kishon@ti.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1473 Lines: 40 On 14/12/17 15:09, Kishon Vijay Abraham I wrote: > Remove SDHCI_QUIRK_BROKEN_CARD_DETECTION quirk as gpio card detection > is supported in sdhci-omap. SDHCI_QUIRK_BROKEN_CARD_DETECTION is for native card detection not gpio card detection. > > Add SDHCI_QUIRK2_PRESET_VALUE_BROKEN quirk as setting preset values loads > incorrect CLKD values (for UHS modes). > > Remove SDHCI_QUIRK2_NO_1_8_V quirk as sdhci-omap now supports UHS modes. > > Signed-off-by: Kishon Vijay Abraham I > --- > drivers/mmc/host/sdhci-omap.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-omap.c b/drivers/mmc/host/sdhci-omap.c > index 594e41200d8a..6dee275b2e57 100644 > --- a/drivers/mmc/host/sdhci-omap.c > +++ b/drivers/mmc/host/sdhci-omap.c > @@ -755,13 +755,12 @@ static int sdhci_omap_set_capabilities(struct sdhci_omap_host *omap_host) > } > > static const struct sdhci_pltfm_data sdhci_omap_pdata = { > - .quirks = SDHCI_QUIRK_BROKEN_CARD_DETECTION | > - SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK | > + .quirks = SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK | > SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN | > SDHCI_QUIRK_NO_HISPD_BIT | > SDHCI_QUIRK_BROKEN_ADMA_ZEROLEN_DESC, > - .quirks2 = SDHCI_QUIRK2_NO_1_8_V | > - SDHCI_QUIRK2_ACMD23_BROKEN | > + .quirks2 = SDHCI_QUIRK2_ACMD23_BROKEN | > + SDHCI_QUIRK2_PRESET_VALUE_BROKEN | > SDHCI_QUIRK2_RSP_136_HAS_CRC, > .ops = &sdhci_omap_ops, > }; >